Merge pull request #477 from Adyen/hotfix/res-body

Author: KadoBOT

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@adyen/api-library",
-  "version": "4.0.1",
+  "version": "4.0.2",
   "description": "The Adyen API Library for NodeJS enables you to work with Adyen APIs.",
   "main": "dist/lib/src/index.js",
   "types": "dist/lib/src/index.d.ts",
@@ -52,17 +52,17 @@
     "kind-of": "^6.0.3",
     "minimist": ">=1.2.3",
     "nock": "12.0.3",
-    "release-it": "13.6.1",
+    "release-it": "13.6.2",
     "ts-auto-mock": "^1.6.0",
     "ts-jest": "25.5.1",
     "ts-loader": "7.0.5",
     "ttypescript": "^1.5.10",
-    "typescript": "3.9.3",
+    "typescript": "3.9.5",
     "webpack": "4.43.0",
     "webpack-cli": "3.3.11"
   },
   "dependencies": {
-    "@types/node": "14.0.5",
+    "@types/node": "14.0.9",
     "https-proxy-agent": "5.0.0"
   }
 }

src/httpClient/httpURLConnectionClient.ts

@@ -116,10 +116,10 @@ class HttpURLConnectionClient implements ClientInterface {
             connectionRequest.flushHeaders();
 
             connectionRequest.on("response", (res: IncomingMessage): void => {
-                const response: { headers: IncomingHttpHeaders; body: (string | Buffer)[] | string; statusCode: number | undefined } = {
+                const response: { headers: IncomingHttpHeaders; body: string; statusCode: number | undefined } = {
                     statusCode: res.statusCode,
                     headers: res.headers,
-                    body: []
+                    body: ""
                 };
 
                 const getException = (responseBody: string): HttpClientException => new HttpClientException({
@@ -132,23 +132,18 @@ class HttpURLConnectionClient implements ClientInterface {
 
                 let exception: HttpClientException | Error = getException(response.body.toString());
 
-                res.on("data", (data: string | Buffer): void => {
-                    (response.body as (string | Buffer)[]).push(data);
+                res.on("data", (chunk: string): void => {
+                    response.body += chunk;
                 });
 
                 res.on("end", (): void => {
                     if (!res.complete) {
                         reject(new Error("The connection was terminated while the message was still being sent"));
                     }
 
-                    if (response.body.length) {
-                        response.body = (response.body as []).join();
-                    }
-
                     if (res.statusCode && (res.statusCode < 200 || res.statusCode >= 300)) {
                         try {
-                            const dataString = response.body.toString();
-                            const formattedData: ApiError | {[key: string]: never} = JSON.parse(dataString);
+                            const formattedData: ApiError | {[key: string]: never} = JSON.parse(response.body);
                             const isApiError = "status" in formattedData;
                             const isRequestError = "errors" in formattedData;
 
@@ -158,12 +153,12 @@ class HttpURLConnectionClient implements ClientInterface {
                                     statusCode: formattedData.status,
                                     errorCode: formattedData.errorCode,
                                     responseHeaders: res.headers,
-                                    responseBody: dataString,
+                                    responseBody: response.body,
                                 });
                             } else if (isRequestError) {
-                                exception = new Error(dataString);
+                                exception = new Error(response.body);
                             } else {
-                                exception = getException(dataString);
+                                exception = getException(response.body);
                             }
                         } catch (e) {
                             reject(exception);