Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic groups to services.json? #382

Open
ainar-g opened this issue Oct 23, 2023 · 2 comments
Open

Add semantic groups to services.json? #382

ainar-g opened this issue Oct 23, 2023 · 2 comments
Assignees
Labels
enhancement Improvement of existent feature

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Oct 23, 2023

services.json has become quite big, and it's getting a bit hard to find the necessary service, even when they're sorted alphabetically.

One of the possible ways to combat this is to introduce some kind of semantic groupings. For example, “Games”, “Streaming”, “Search engines”, etc.

As a rough draft, something along the lines of:

{
  "blocked_services": [
    {
      "group": "game",
      "id": "minecraft",
      "name": "Minecraft",
      "rules": []
    }
  ],
  "groups": [
    {
      "id": "game"
    },
    {
      "id": "streaming"
    }
  ]
}

Group names will probably require i18n based on their IDs, so the IDs must remain unchanged.

/cc @ameshkov, @Alex-302

@lutfor-diu
Copy link

group/type wise

@joel72265
Copy link

joel72265 commented Nov 2, 2023

Thank you for a wonderful application. I agree, Allow Grouping of services, custom domains and assign these groups to Clients.

eg.
Group/Tag A: Entertainment (Direct TV, ESPN, FIFA....)
Group/Tag B: Social Media (Facebook, Instagram, ...)

Assign these blocked groups to Clients
Client 1: assign Group A, Group B
Client 2: assign Group A
Uploading AdGuard03.jpg…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existent feature
Projects
None yet
Development

No branches or pull requests

4 participants