Resolved all violations reported by Flake8

Author: HugoGGuerrier

lkql_checker/doc/share/conf.py

@@ -6,6 +6,7 @@
 
 from os import path as P
 import sys
+from sphinx.highlighting import lexers
 import time
 
 # Add own dir path
@@ -22,14 +23,12 @@
 
 sys.path.append(lkql_user_manual_path)
 
-import ada_pygments
-import latex_elements
-import lkql_lexer
+import ada_pygments  # noqa: E402
+import latex_elements  # noqa: E402
+import lkql_lexer  # noqa: E402
 
 # -- General configuration ---------------------------------------------------
 
-from sphinx.highlighting import lexers
-
 lexers["lkql"] = lkql_lexer.LKQLPygmentsLexer()
 lexers["ada"] = ada_pygments.AdaLexer()
 lexers["gpr"] = ada_pygments.GNATProjectLexer()

lkql_jit/standalone/make_native.py

@@ -1,3 +1,11 @@
+import os
+import subprocess
+import sys
+from pathlib import Path
+
+sys.path.append("..")
+from utils import GraalManager, parse_args, is_windows  # noqa E402
+
 """----------------------------------------------------------------------------
 --                             L K Q L   J I T                              --
 --                                                                          --
@@ -40,16 +48,6 @@
 specified at any other place.
 """
 
-import os
-import subprocess
-import sys
-
-from pathlib import Path
-
-sys.path.append("..")
-# noinspection PyUnresolvedReferences
-from utils import GraalManager, parse_args, is_windows
-
 
 def look_for_files_in_env(files: list[str], env_var_name: str) -> dict[str, str] | None:
     """

obj/debug/main-gdb.py

@@ -4,7 +4,6 @@
 dir_path = os.path.dirname(os.path.realpath(__file__))
 printers_path = os.path.join(dir_path, "..", "..")
 
-
 sys.path.append(printers_path)
 
-import printers
+import printers  # noqa: E402,F401

testsuite/drivers/base_driver.py

@@ -100,7 +100,10 @@ def errors(self) -> list[tuple[int, str]]:
                 res.append(
                     (
                         line,
-                        f"unexpected flag count (expecting {flag_count}, actual {count})",
+                        (
+                            f"unexpected flag count (expecting {flag_count}, actual "
+                            f"{count})"
+                        ),
                     )
                 )
 
@@ -132,7 +135,8 @@ def add_missing_flags(self):
         # source.
         if len(self.matching_sources) > 1:
             raise TestAbortWithError(
-                f"Cannot automatically add flags annotations in {self.file_name}, multiple sources are matching this name"
+                f"Cannot automatically add flags annotations in {self.file_name}, "
+                "multiple sources are matching this name"
             )
         source = self.matching_sources[0]
 
@@ -503,7 +507,7 @@ def read_ada_file(cls, file_name: str) -> tuple[list[str], str]:
                     lines = ada_bytes.decode(encoding).split("\n")
                     lines = lines[:-1] if not lines[-1] else lines
                     return (lines, encoding)
-                except ValueError as _:
+                except ValueError:
                     pass
 
     def _define_lkql_executables(self) -> None:

testsuite/drivers/benchmarks_driver.py

@@ -28,7 +28,7 @@ def run(self):
             os.path.join(self.lkql_jit_dir, "benchmarks"),
             "jmh:benchmark",
             "-Djmh.rf=json",
-            f"-Djmh.v=SILENT",
+            "-Djmh.v=SILENT",
             f"-Djmh.rff={benchmark_results_json}",
         ]
         self.shell(

testsuite/drivers/checker_driver.py

@@ -83,8 +83,8 @@ def run(self) -> None:
                 if auto_fix_mode in ["NEW_FILE", "PATCH_FILE"]:
                     # Get the list of patched files by parsing the output
                     patched_files = []
-                    for l in str(self.output).splitlines():
-                        search_result = patched_file_pattern.search(l)
+                    for line in str(self.output).splitlines():
+                        search_result = patched_file_pattern.search(line)
                         if search_result is not None:
                             groups = search_result.groups()
                             patched_files.append(groups[2] or groups[0])

testsuite/drivers/gnatcheck_driver.py

@@ -137,7 +137,8 @@ class GnatcheckDriver(BaseDriver):
     output_formats = set(["brief", "full", "short", "xml"])
 
     flag_line_pattern = re.compile(
-        rf"^({BaseDriver.ada_file_pattern}):(\d+):\d+: (rule violation|warning|error): .*$"
+        rf"^({BaseDriver.ada_file_pattern}):(\d+):\d+: (rule violation|warning|error)"
+        ": .*$"
     )
 
     @classmethod
@@ -415,7 +416,7 @@ def run_one_test(test_data: dict[str, any]) -> None:
             exe = GnatcheckDriver.modes[test_data.get("mode", "gnatcheck")]
             args = [exe, "-q"]
             output_file_name = test_data.get("output_file")
-            if output_file_name is None or output_file_name == True:
+            if output_file_name is None or output_file_name is True:
                 output_file_name = self.working_dir(
                     f"{exe}.{'xml' if output_format == 'xml' else 'out'}"
                 )
@@ -635,12 +636,13 @@ def run_one_test(test_data: dict[str, any]) -> None:
                                 # include in the test baseline.
                                 report_file_content = "".join(f.readlines()[9:])
                             has_output_file = True
-                    except FileNotFoundError as _:
+                    except FileNotFoundError:
                         self.output += (
                             "testsuite_driver: No output file generated by gnatcheck\n"
                         )
 
-                # Get the lines flagged by the test running and add it to all flagged lines
+                # Get the lines flagged by the test running and add it to all flagged
+                # lines.
                 if self.flag_checking and (has_output_file or output_format == "brief"):
                     add_to_files_flagged_lines(
                         self.parse_flagged_lines(

testsuite/drivers/interpreter_driver.py

@@ -66,7 +66,9 @@ def compute_failures(self):
                     None,
                     baseline,
                     self.lkt_output,
-                    failure_message="execution after refactor TO_LKQL_V2: unexpected output",
+                    failure_message=(
+                        "execution after refactor TO_LKQL_V2: unexpected output"
+                    ),
                 )
 
             case False:

user_manual/source/conf.py

@@ -24,7 +24,7 @@
 dir_path = os.path.dirname(os.path.realpath(__file__))
 sys.path.append(dir_path)
 
-import lkql_lexer
+import lkql_lexer  # noqa: E402
 
 project = "LKQL"
 copyright = "2020, AdaCore"

user_manual/source/lkql_doc_class.py

@@ -16,7 +16,7 @@
     LKQL_CLASSES = [
         v
         for _, v in liblkqllang.__dict__.items()
-        if (type(v) == type and issubclass(v, liblkqllang.LkqlNode))
+        if (type(v) is type and issubclass(v, liblkqllang.LkqlNode))
     ]
 
 except ImportError: