diff --git a/app/__init__.py b/app/__init__.py index 2764c4cc8..60a150ece 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -15,8 +15,7 @@ def create_app(test_config=None): app.config["SQLALCHEMY_TRACK_MODIFICATIONS"] = False if test_config is None: - app.config["SQLALCHEMY_DATABASE_URI"] = os.environ.get( - "SQLALCHEMY_DATABASE_URI") + app.config['SQLALCHEMY_DATABASE_URI'] = os.environ.get("RENDER_DATABASE_URI") else: app.config["TESTING"] = True app.config["SQLALCHEMY_DATABASE_URI"] = os.environ.get( @@ -30,5 +29,10 @@ def create_app(test_config=None): migrate.init_app(app, db) # Register Blueprints here + from app.routes.task_routes import tasks_bp + app.register_blueprint(tasks_bp) + + from app.routes.goal_routes import goals_bp + app.register_blueprint(goals_bp) return app diff --git a/app/helper_functions.py b/app/helper_functions.py new file mode 100644 index 000000000..a16bb2672 --- /dev/null +++ b/app/helper_functions.py @@ -0,0 +1,34 @@ +from flask import abort, make_response, request, jsonify +import requests +from dotenv import load_dotenv +import os +load_dotenv() + +def validate_model(cls, model_id): + try: + model_id = int(model_id) + except: + abort(make_response({"message":f"{cls.__name__} {model_id} invalid"}, 400)) + + model = cls.query.get(model_id) + + if not model: + abort(make_response({"message":f"{cls.__name__} {model_id} not found"}, 404)) + + return model + +def slack_mark_complete(self): + API_KEY= os.environ.get("API_KEY") + url = "https://slack.com/api/chat.postMessage" + + data = { + "channel": "#task-list-api", + "text": f"Someone just completed the task {self.title}" + } + headers = { + 'Authorization': f'{API_KEY}' + } + + response = requests.post(url, headers=headers, data=data) + + print(response.text) \ No newline at end of file diff --git a/app/models/goal.py b/app/models/goal.py index b0ed11dd8..9e5201d41 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -1,5 +1,38 @@ from app import db - class Goal(db.Model): goal_id = db.Column(db.Integer, primary_key=True) + title = db.Column(db.String, nullable=False) + tasks = db.relationship("Task", back_populates ="goal", lazy= True) + + + def to_dict(self): + + goal_as_dict = { + "id": self.goal_id, + "title": self.title, + } + if self.tasks: + goal_as_dict["task_ids"] = [task.to_dict() for task in self.tasks] + + return goal_as_dict + + + def to_json(self): + + json_tasks = [] + + for task in self.tasks: + json_tasks.append(task.to_json()) + + return{ + "id": self.goal_id, + "title": self.title, + "tasks": json_tasks + } + + + @classmethod + def from_dict(cls, goal_data): + new_goal = Goal(title=goal_data["title"]) + return new_goal diff --git a/app/models/task.py b/app/models/task.py index c91ab281f..8df77d8b7 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,89 @@ from app import db - +from app.models.goal import Goal +from datetime import datetime +import requests +from dotenv import load_dotenv +import os +load_dotenv() class Task(db.Model): task_id = db.Column(db.Integer, primary_key=True) + title = db.Column(db.String, nullable=False) + description = db.Column(db.String, nullable=False) + completed_at = db.Column(db.DateTime, default=None, nullable = True) + goal_id = db.Column(db.Integer, db.ForeignKey("goal.goal_id"), nullable = True) + goal = db.relationship("Goal", back_populates= "tasks") + + + + def to_dict(self): + task_as_dict = {} + task_as_dict["task_id"] = self.task_id + task_as_dict["title"] = self.title + task_as_dict["description"] = self.description + task_as_dict["completed_at"] = self.completed_at + if self.goal_id: + task_as_dict["goal_id"] =self.goal_id + + return task_as_dict + + def to_json(self): + if self.completed_at: + is_complete = True + else: + is_complete = False + + if self.goal_id: + return{ + "id": self.task_id, + "title": self.title, + "description": self.description, + "is_complete": is_complete, + "goal_id": self.goal_id + } + else: + + return{ + "id": self.task_id, + "title": self.title, + "description": self.description, + "is_complete": is_complete + } + + # def to_json_tasks(self): + + + # return{ + # "id": self.goal_id, + # "title": self.title + # } + + + @classmethod + def from_dict(cls, task_data): + new_task = Task(title=task_data["title"], + description=task_data["description"] + ) + return new_task + + def mark_complete(self, request_body): + self.completed_at = datetime.utcnow() + + def mark_incomplete(self, request_body): + self.completed_at = None + + def slack_mark_complete(self): + API_KEY = os.environ.get("API_KEY") + url = "https://slack.com/api/chat.postMessage" + + data = { + "channel": "#task-list-api", + "text": f"Someone just completed the task {self.title}" + } + headers = { + 'Authorization': f'{API_KEY}' + } + + response = requests.post(url, headers=headers, data=data) + + print(response.text) \ No newline at end of file diff --git a/app/routes.py b/app/routes.py deleted file mode 100644 index 3aae38d49..000000000 --- a/app/routes.py +++ /dev/null @@ -1 +0,0 @@ -from flask import Blueprint \ No newline at end of file diff --git a/app/routes/__init__.py b/app/routes/__init__.py new file mode 100644 index 000000000..e69de29bb diff --git a/app/routes/goal_routes.py b/app/routes/goal_routes.py new file mode 100644 index 000000000..acfb802bf --- /dev/null +++ b/app/routes/goal_routes.py @@ -0,0 +1,96 @@ +from app import db +from flask import Blueprint, jsonify, make_response, request +from app.models.goal import Goal +from app.models.task import Task +from app.helper_functions import validate_model + +goals_bp = Blueprint("goals_bp", __name__, url_prefix="/goals") + +@goals_bp.route("", methods=["GET"]) +def read_all_goals(): + + title_query = request.args.get("title") + if title_query: + goals = Goal.query.filter_by(title=title_query) + + if request.args.get("sort") == "asc": + goals = Goal.query.order_by(Goal.title.asc()).all() + + elif request.args.get("sort") == "desc": + goals = Goal.query.order_by(Goal.title.desc()).all() + + else: + goals = Goal.query.all() + + goals_response = [] + for goal in goals: + goals_response.append(goal.to_dict()) + return jsonify(goals_response), 200 + +#GET route to read one task +@goals_bp.route("/", methods=["GET"]) +def read_one_task(goal_id): + goal = validate_model(Goal,goal_id) + return jsonify({"goal": goal.to_dict()}), 200 + +@goals_bp.route("", methods=["POST"]) +def create_goal(): + request_body = request.get_json() + + if "title" not in request_body: + return make_response({"details": "Invalid data"}, 400) + + new_goal = Goal.from_dict(request_body) + + db.session.add(new_goal) + db.session.commit() + + return make_response({"goal":new_goal.to_dict()}), 201 + +#UPDATE route to edit a goal +@goals_bp.route("/", methods=["PUT"]) +def update_goal(goal_id): + goal = validate_model(Goal, goal_id) + + request_body = request.get_json() + + goal.title = request_body["title"] + + db.session.commit() + + return make_response({"goal": goal.to_dict()}), 200 + +#DELETE existing goal +@goals_bp.route("/", methods=["DELETE"]) +def delete_goal(goal_id): + goal = validate_model(Goal, goal_id) + + db.session.delete(goal) + db.session.commit() + + return make_response({"details": f"Goal {goal.goal_id} \"{goal.title}\" successfully deleted"}) + + +#POST ROUTE +@goals_bp.route("//tasks", methods=["POST"]) +def link_tasks_to_goal(goal_id): + + goal = validate_model(Goal, goal_id) + request_body = request.get_json() + + for task_id in request_body["task_ids"]: + task = validate_model(Task, task_id) + task.goal_id = goal_id + db.session.add(task) + + db.session.commit() + + return make_response({"id": goal.goal_id, "task_ids":request_body["task_ids"]}), 200 + + +@goals_bp.route("//tasks", methods=["GET"]) +def read_goal_tasks(goal_id): + + goal = validate_model(Goal, goal_id) + + return make_response(goal.to_json()), 200 diff --git a/app/routes/task_routes.py b/app/routes/task_routes.py new file mode 100644 index 000000000..e1ec25fbf --- /dev/null +++ b/app/routes/task_routes.py @@ -0,0 +1,110 @@ +from app import db +from flask import Blueprint, jsonify,make_response, request +from app.models.task import Task +from app.models.goal import Goal +from app.helper_functions import slack_mark_complete, validate_model + +tasks_bp = Blueprint("tasks_bp", __name__, url_prefix="/tasks") + +# POST route for creating a task +@tasks_bp.route("", methods=["POST"]) +def create_task(): + request_body = request.get_json() + + if "title" not in request_body or "description" not in request_body: + return make_response({"details": "Invalid data"}, 400) + + new_task = Task.from_dict(request_body) + + db.session.add(new_task) + db.session.commit() + + return make_response({"task":new_task.to_json()}), 201 + +# GET route for reading all tasks +@tasks_bp.route("", methods=["GET"]) +def read_all_tasks(): + + title_query = request.args.get("title") + if title_query: + tasks = Task.query.filter_by(title=title_query) + + description_query = request.args.get("description") + if description_query: + tasks = Task.query.filter_by(description=description_query) + + completed_query = request.args.get("is_complete") + if completed_query: + tasks = Task.query.filter_by(is_completed = completed_query) + + if request.args.get("sort") == "asc": + tasks = Task.query.order_by(Task.title.asc()).all() + + elif request.args.get("sort") == "desc": + tasks = Task.query.order_by(Task.title.desc()).all() + + else: + tasks = Task.query.all() + + + tasks_response = [] + for task in tasks: + tasks_response.append(task.to_json()) + return jsonify(tasks_response), 200 + +#GET route to read one task +@tasks_bp.route("/", methods=["GET"]) +def read_one_task(task_id): + task = validate_model(Task,task_id) + return jsonify({"task": task.to_json()}), 200 + +#UPDATE route to edit a task +@tasks_bp.route("/", methods=["PUT"]) +def update_task(task_id): + task = validate_model(Task, task_id) + + request_body = request.get_json() + + task.title = request_body["title"] + task.description = request_body["description"] + + db.session.commit() + + return make_response({"task": task.to_json()}), 200 + +#DELETE existing task +@tasks_bp.route("/", methods=["DELETE"]) +def delete_task(task_id): + task = validate_model(Task, task_id) + + db.session.delete(task) + db.session.commit() + + return make_response({"details": f"Task {task.task_id} \"{task.title}\" successfully deleted"}) + +#PATCH REQUEST marking a test complete +@tasks_bp.route("//mark_complete", methods=["PATCH"]) +def update_complete_status(task_id): + task_completed = validate_model(Task, task_id) + + request_body = request.get_json() + + task_completed.mark_complete(request_body) + + db.session.commit() + + slack_mark_complete(task_completed) + + return jsonify({"task":task_completed.to_json()}), 200 + + +@tasks_bp.route("//mark_incomplete", methods=["PATCH"]) +def update_incomplete_status(task_id): + task_to_update = validate_model(Task, task_id) + request_body = request.get_json() + + task_to_update.mark_incomplete(request_body) + + db.session.commit() + return jsonify({"task":task_to_update.to_json()}), 200 + diff --git a/cli/task_list.py b/cli/task_list.py index 137f3fa06..723f5dbb9 100644 --- a/cli/task_list.py +++ b/cli/task_list.py @@ -5,7 +5,7 @@ def parse_response(response): if response.status_code >= 400: return None - + print(response.json()) return response.json()["task"] def create_task(title, description, completed_at=None): diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/18fe52030e71_.py b/migrations/versions/18fe52030e71_.py new file mode 100644 index 000000000..d7378ce0f --- /dev/null +++ b/migrations/versions/18fe52030e71_.py @@ -0,0 +1,28 @@ +"""empty message + +Revision ID: 18fe52030e71 +Revises: a1a03c3c1962 +Create Date: 2023-05-11 13:20:27.255348 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '18fe52030e71' +down_revision = 'a1a03c3c1962' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('goal', sa.Column('title', sa.String(), nullable=False)) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_column('goal', 'title') + # ### end Alembic commands ### diff --git a/migrations/versions/4a5f0a5f001c_.py b/migrations/versions/4a5f0a5f001c_.py new file mode 100644 index 000000000..9b8f6d964 --- /dev/null +++ b/migrations/versions/4a5f0a5f001c_.py @@ -0,0 +1,39 @@ +"""empty message + +Revision ID: 4a5f0a5f001c +Revises: +Create Date: 2023-05-07 15:20:26.876760 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '4a5f0a5f001c' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('goal_id', sa.Integer(), nullable=False), + sa.PrimaryKeyConstraint('goal_id') + ) + op.create_table('task', + sa.Column('task_id', sa.Integer(), nullable=False), + sa.Column('title', sa.String(), nullable=True), + sa.Column('description', sa.String(), nullable=True), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.PrimaryKeyConstraint('task_id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/migrations/versions/6ae3cf792eef_adds_relationship_between_goal_and_tasks.py b/migrations/versions/6ae3cf792eef_adds_relationship_between_goal_and_tasks.py new file mode 100644 index 000000000..8eaa80be4 --- /dev/null +++ b/migrations/versions/6ae3cf792eef_adds_relationship_between_goal_and_tasks.py @@ -0,0 +1,30 @@ +"""adds relationship between goal and tasks + +Revision ID: 6ae3cf792eef +Revises: 18fe52030e71 +Create Date: 2023-05-11 17:13:39.759630 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '6ae3cf792eef' +down_revision = '18fe52030e71' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('task', sa.Column('goal_id', sa.Integer(), nullable=True)) + op.create_foreign_key(None, 'task', 'goal', ['goal_id'], ['goal_id']) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_constraint(None, 'task', type_='foreignkey') + op.drop_column('task', 'goal_id') + # ### end Alembic commands ### diff --git a/migrations/versions/a1a03c3c1962_.py b/migrations/versions/a1a03c3c1962_.py new file mode 100644 index 000000000..5e7b00a7a --- /dev/null +++ b/migrations/versions/a1a03c3c1962_.py @@ -0,0 +1,38 @@ +"""empty message + +Revision ID: a1a03c3c1962 +Revises: 4a5f0a5f001c +Create Date: 2023-05-07 16:33:19.888880 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'a1a03c3c1962' +down_revision = '4a5f0a5f001c' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.alter_column('task', 'title', + existing_type=sa.VARCHAR(), + nullable=False) + op.alter_column('task', 'description', + existing_type=sa.VARCHAR(), + nullable=False) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.alter_column('task', 'description', + existing_type=sa.VARCHAR(), + nullable=True) + op.alter_column('task', 'title', + existing_type=sa.VARCHAR(), + nullable=True) + # ### end Alembic commands ### diff --git a/requirements.txt b/requirements.txt index 453f0ef6a..b1319b991 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,34 +1,38 @@ -alembic==1.5.4 -attrs==20.3.0 -autopep8==1.5.5 +alembic==1.7.7 +attrs==21.4.0 +autopep8==1.6.0 blinker==1.4 -certifi==2020.12.5 +certifi==2021.10.8 chardet==4.0.0 -click==7.1.2 -Flask==1.1.2 -Flask-Migrate==2.6.0 -Flask-SQLAlchemy==2.4.4 +charset-normalizer==2.0.12 +click==8.1.2 +Flask==2.1.1 +Flask-Migrate==3.1.0 +Flask-SQLAlchemy==2.5.1 +greenlet==1.1.3 gunicorn==20.1.0 -idna==2.10 +idna==3.3 +importlib-metadata==4.11.3 iniconfig==1.1.1 -itsdangerous==1.1.0 -Jinja2==2.11.3 -Mako==1.1.4 -MarkupSafe==1.1.1 -packaging==20.9 -pluggy==0.13.1 +itsdangerous==2.1.2 +Jinja2==3.1.1 +Mako==1.2.0 +MarkupSafe==2.1.1 +packaging==21.3 +pluggy==1.0.0 psycopg2-binary==2.9.5 py==1.11.0 -pycodestyle==2.6.0 -pyparsing==2.4.7 +pycodestyle==2.8.0 +pyparsing==3.0.7 pytest==7.1.1 -pytest-cov==2.12.1 -python-dateutil==2.8.1 -python-dotenv==0.15.0 +python-dateutil==2.8.2 +python-dotenv==0.20.0 python-editor==1.0.4 -requests==2.25.1 -six==1.15.0 -SQLAlchemy==1.3.23 +requests==2.27.1 +six==1.16.0 +SQLAlchemy==1.4.35 toml==0.10.2 -urllib3==1.26.5 -Werkzeug==1.0.1 +tomli==2.0.1 +urllib3==1.26.9 +Werkzeug==2.1.1 +zipp==3.7.0 diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..a0d6683d0 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +13,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +32,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -51,7 +51,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -59,14 +59,15 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 + assert response_body == {"message":"Task 1 not found"} + # raise Exception("Complete test with assertion about response body") - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + # # ***************************************************************** + # # **Complete test with assertion about response body*************** + # # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -93,7 +94,7 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -119,7 +120,7 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -130,14 +131,14 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 + assert response_body == {"message":"Task 1 not found"} + # raise Exception("Complete test with assertion about response body") + # # ***************************************************************** + # # **Complete test with assertion about response body*************** + # # ***************************************************************** - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +153,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -160,16 +161,17 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 + assert response_body == {"message":"Task 1 not found"} + assert Task.query.all() == [] - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + # raise Exception("Complete test with assertion about response body") + # # ***************************************************************** + # # **Complete test with assertion about response body*************** + # # ***************************************************************** - assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +188,7 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..651e3aebd 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 32d379822..32d2a7191 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -5,7 +5,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -42,7 +42,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -62,7 +62,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -99,7 +99,7 @@ def test_mark_complete_on_completed_task(client, completed_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -119,7 +119,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -127,14 +127,16 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == { + "message":"Task 1 not found"} - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -142,8 +144,10 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == { + "message":"Task 1 not found"} - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..a5476389e 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,8 @@ import pytest +from app.models.goal import Goal -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +13,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +30,7 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +47,22 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") + # raise Exception("Complete test") # Assert # ---- Complete Test ---- - # assertion 1 goes here - # assertion 2 goes here + assert response.status_code == 404 + assert response_body == {"message":"Goal 1 not found"} # ---- Complete Test ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +81,44 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") + # raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + + }) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 200 + assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal Title" + } + } + goal = Goal.query.get(1) + assert goal.title == "Updated Goal Title" -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") + # raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title", + }) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert response_body == {"message":"Goal 1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -123,28 +134,27 @@ def test_delete_goal(client, one_goal): # Check that the goal was deleted response = client.get("/goals/1") assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + assert "details" in response_body + assert response_body == { + "details": 'Goal 1 "Build a habit of going outside daily" successfully deleted' + } + assert Goal.query.get(1) == None -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") - + # raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.delete("/goals/1") + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert response_body == {"message":"Goal 1 not found"} + assert Goal.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 8afa4325e..9b96855ad 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -23,7 +23,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(Goal.query.get(1).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -42,7 +42,7 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on assert len(Goal.query.get(1).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -51,13 +51,10 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + assert {"message":"Task 1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -74,7 +71,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -99,7 +96,7 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()