Skip to content

Commit a09ce30

Browse files
deadlyjackAjit Kumar
andauthored
fix: ad references, terminal HTTP safety, banner sync, and defense fixes (#2169)
* fix: ad references, terminal HTTP safety, banner sync, and defense fixes - Replace window.ad/window.iad with module-level bannerAd/interstitialAd imports from startAd.js across adRewards, helpers, keyboard, remoteStorage, plugin, and extensions modules - Export ad unit IDs, bannerAd, interstitialAd, and initialized from startAd for consistent module-level references - Guard terminal createPid/resize/terminate against missing cordova HTTP plugin with null-safe sendRequest lookup and improved error fallback - Restore admob?.RewardedAd guard in createRewardedAd and adUnitIdRewarded check in isRewardedSupported - Fix banner ad toggle to fire on every resume event, not just on height change - Skip system.clearCache on fresh install by adding previousVersionCode != null check - Escape regex special chars in font name before building @font-face regex - Add error logging to previously silent catch block in devTools eruda download - Restore rating-medium CSS class for 50-79% plugin ratings in plugin.view.js - Fix ES6 detection in index.html by invoking the returned arrow function - Add trailing newline to index.html Or a shorter version: fix: tighten ad references, terminal safety, and defensive fixes Replace global window.ad/window.iad with module-level exports from startAd.js. Add cordova HTTP plugin availability guards in terminal (create/resize/terminate). Restore missing safety checks in adRewards (RewardedAd guard, unit ID check). Fix banner ad not syncing on resume without keyboard height change, skip clearCache on fresh install, escape font name in regex, and fix silent catch in devTools eruda download. * fix: linting * fix: review changes --------- Co-authored-by: Ajit Kumar <dellevenjack@gmail>
1 parent c1ff3f7 commit a09ce30

48 files changed

Lines changed: 829 additions & 519 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

config.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
<preference name="androidxEnabled" value="true" />
3939
<preference name="GradlePluginKotlinEnabled" value="true" />
4040
<preference name="android-targetSdkVersion" value="36" />
41+
<preference name="android-minSdkVersion" value="26" />
4142

4243

4344
<edit-config file="app/src/main/AndroidManifest.xml" mode="merge"

package-lock.json

Lines changed: 16 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@
4040
"cordova-plugin-sftp": {},
4141
"com.foxdebug.acode.rk.exec.terminal": {},
4242
"com.foxdebug.acode.rk.plugin.plugincontext": {},
43-
"cordova-plugin-system": {},
4443
"com.foxdebug.acode.rk.auth": {},
4544
"com.foxdebug.acode.rk.exec.proot": {},
4645
"cordova-plugin-iap": {},
47-
"com.foxdebug.acode.rk.customtabs": {}
46+
"com.foxdebug.acode.rk.customtabs": {},
47+
"cordova-plugin-system": {}
4848
},
4949
"platforms": [
5050
"android"
@@ -194,5 +194,5 @@
194194
"@codemirror/state": "^6.6.0",
195195
"@codemirror/view": "^6.42.1"
196196
},
197-
"browserslist": "cover 100%,not android < 5"
197+
"browserslist": "cover 100%"
198198
}

rspack.config.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,6 @@ module.exports = (env, options) => {
2626
syntax: 'typescript',
2727
tsx: false,
2828
},
29-
transform: {
30-
// react: {
31-
// pragma: 'tag',
32-
// pragmaFrag: 'Array',
33-
// throwIfNamespace: false,
34-
// development: false,
35-
// useBuiltins: false,
36-
// runtime: 'classic',
37-
// },
38-
},
3929
target: 'es2015',
4030
},
4131
},

src/components/audioPlayer/style.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
@supports not (gap: 1px) {
2+
.audio-player > * + * { margin-left: 15px; }
3+
.volume-control > * + * { margin-left: 8px; }
4+
}
5+
16
.audio-player {
27
background: var(--primary-color, #1e1e1e);
38
border-radius: 10px;

src/components/lspInfoDialog/styles.scss

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -454,4 +454,20 @@
454454
font-weight: 600;
455455
color: var(--popup-text-color);
456456
font-family: monospace;
457+
}
458+
459+
@supports not (gap: 1px) {
460+
.lsp-list-actions > * + * { margin-left: 8px; }
461+
.lsp-action-btn > * + * { margin-left: 6px; }
462+
.lsp-server-item > * + * { margin-left: 12px; }
463+
.lsp-server-info > * + * { margin-top: 2px; }
464+
.lsp-details-header > * + * { margin-left: 8px; }
465+
.lsp-header-actions > * + * { margin-left: 4px; }
466+
.lsp-details-title > * + * { margin-left: 10px; }
467+
.lsp-chip-container > * { margin-right: 5px; margin-bottom: 5px; }
468+
.lsp-logs-actions > * + * { margin-left: 2px; }
469+
.lsp-log > * + * { margin-left: 6px; }
470+
.lsp-logs-title > * + * { margin-left: 4px; }
471+
.lsp-stats-container > * + * { margin-left: 16px; }
472+
.lsp-stat > * + * { margin-left: 6px; }
457473
}

src/components/lspStatusBar/style.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,14 @@ wc-page:not([footer-height]) #lsp-status-bar {
163163
bottom: 10px;
164164
}
165165

166+
@supports not (gap: 1px) {
167+
#lsp-status-bar {
168+
.lsp-status-content > * + * { margin-left: 10px; }
169+
.lsp-status-text > * + * { margin-top: 2px; }
170+
.lsp-status-progress > * + * { margin-left: 8px; }
171+
}
172+
}
173+
166174
@keyframes lspStatusSlideUp {
167175
from {
168176
transform: translateY(100%);

src/components/referencesPanel/styles.scss

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,21 @@
298298
}
299299
}
300300

301+
@supports not (gap: 1px) {
302+
.references-panel {
303+
.header-content > * + * { margin-top: 2px; }
304+
.header-title > * + * { margin-left: 8px; }
305+
.header-actions > * + * { margin-left: 4px; }
306+
.loading-state > * + * { margin-left: 12px; }
307+
}
308+
.ref-file-header > * + * { margin-left: 8px; }
309+
.ref-item > * + * { margin-left: 10px; }
310+
.references-tab-container {
311+
.header-info > * + * { margin-left: 10px; }
312+
.loading-state > * + * { margin-left: 12px; }
313+
}
314+
}
315+
301316
.references-tab-container {
302317
display: flex;
303318
flex-direction: column;

0 commit comments

Comments
 (0)