Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and remove all unwraps inside the code #60

Open
okynos opened this issue Jun 20, 2022 · 1 comment
Open

Review and remove all unwraps inside the code #60

okynos opened this issue Jun 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@okynos
Copy link
Member

okynos commented Jun 20, 2022

Hello!

From Reddit post https://www.reddit.com/r/rust/comments/vg1ikg/question_discussion_why_is_unwrap_so_heavily/ and thanks to Reddit user /u/WrongJudgment6. We detected some bad code using unwraps instead of manage the Result/Options as is needed.
Tasks:

  • Review unwrap calls
  • Change to Result/Option management.
  • Test
  • Deploy
  • Enjoy!
@okynos okynos added the bug Something isn't working label Nov 10, 2022
@okynos okynos self-assigned this Jan 11, 2023
@okynos okynos added enhancement New feature or request and removed bug Something isn't working labels Jan 11, 2023
@okynos
Copy link
Member Author

okynos commented Jan 11, 2023

We will review the code to avoid None unwraps

@okynos okynos removed their assignment Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@okynos