Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Improvement #70

Closed
5 of 6 tasks
Acclorite opened this issue Sep 18, 2024 · 5 comments
Closed
5 of 6 tasks

Reader Improvement #70

Acclorite opened this issue Sep 18, 2024 · 5 comments
Assignees

Comments

@Acclorite
Copy link
Owner

Acclorite commented Sep 18, 2024

Various Reader enhancements to improve user experience.

Task list (may extend)

@Acclorite Acclorite converted this from a draft issue Sep 18, 2024
@Acclorite Acclorite added the 🚀 Feature request New feature request or improvement label Sep 18, 2024
@Acclorite Acclorite self-assigned this Sep 18, 2024
@pluseach
Copy link

Would it be possible to implement a Material You reader, or at least have the color scheme follow the system/app themes?

@Acclorite
Copy link
Owner Author

Would it be possible to implement a Material You reader, or at least have the color scheme follow the system/app themes?

Are you sure you got it right? When you add new color preset it sets colors according to MaterialYou theme. As for UI, it does follow Material3 guidelines as far as I can say.

@pluseach
Copy link

pluseach commented Sep 27, 2024

Are you sure you got it right? When you add new color preset it sets colors according to MaterialYou theme. As for UI, it does follow Material3 guidelines as far as I can say.

It seems I didn't explain that very well, my apologies. What I meant was that the reader menu, when you're reading the book, the color preset doesn't match the theme of the material you.

Here, as you can see, I know I could set it manually... but it would be nice if it did so automatically. Some dark versions, like AMOLED and basic dark, would be great:

edit: My apologies again. I didn't know that clicking "+" to add a new preset would automatically set it and follow the MaterialYou's colors. Maybe adding color preset buttons like 'AMOLED' or 'Dark' would help users avoid confusion?"

Screenshot_20240927-101727_Book's Story

@Acclorite
Copy link
Owner Author

Maybe adding color preset buttons like 'AMOLED' or 'Dark' would help users avoid confusion?

I'll think about ways to do it more user-friendly, thanks.

@Acclorite Acclorite closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Book's Story: Development roadmap Sep 27, 2024
@Acclorite Acclorite removed the 🚀 Feature request New feature request or improvement label Sep 27, 2024
@Acclorite
Copy link
Owner Author

Moved progress to Reader Improvement milestone.
Moved discussion to #87.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants