Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] deploy asset fails if pre-existing CBBK-dependencies are not also deployed #2035

Closed
2 tasks done
JoernBerkefeld opened this issue Jan 30, 2025 · 1 comment · Fixed by #2051
Closed
2 tasks done

[BUG] deploy asset fails if pre-existing CBBK-dependencies are not also deployed #2035

JoernBerkefeld opened this issue Jan 30, 2025 · 1 comment · Fixed by #2051
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/asset COMPONENT PRIORITY used for professional service clients
Milestone
7.7.0

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Jan 30, 2025 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

looks like caching is broken here

Image

looks like this happens specifically for contentblockbykey references

Expected Behavior

not having to use --dependencies if the components are already there

Steps To Reproduce

  1. copy a NEW or UPDATED asset to deploy folder that loads another, pre-existing asset via ContentBlockByKey
  2. attempt to deploy it
  3. See an error about not finding the actually existing component

Version

7.6.3

Participation

  • I am willing to submit a pull request for this issue.
@JoernBerkefeld JoernBerkefeld added bug Something isn't working PRIORITY used for professional service clients labels Jan 30, 2025
@JoernBerkefeld JoernBerkefeld added this to the 7.7.0 milestone Jan 30, 2025
@JoernBerkefeld JoernBerkefeld added the c/asset COMPONENT label Feb 5, 2025
@JoernBerkefeld JoernBerkefeld changed the title [BUG] deploy asset fails if CBBK-dependencies are not also deployed [BUG] deploy asset fails if pre-existing CBBK-dependencies are not also deployed Feb 5, 2025
@JoernBerkefeld JoernBerkefeld self-assigned this Feb 5, 2025
JoernBerkefeld added a commit that referenced this issue Feb 5, 2025
@JoernBerkefeld
#2035: ensure dependencies that are not in the deployment package don…
4e39b36 
…t end up in the list of keys to be deployed
JoernBerkefeld added a commit that referenced this issue Feb 5, 2025
@JoernBerkefeld
#2035: ensure pre-existing items are found by adding already cached a…
a422fa9 
…ssets to CBBK reference map
JoernBerkefeld added a commit that referenced this issue Feb 5, 2025
@JoernBerkefeld
#2035: ensure assets with missing referenced content blocks get skipp…
54fe301 
…ed during deployment
@JoernBerkefeld JoernBerkefeld mentioned this issue Feb 5, 2025
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Feb 5, 2025 that will close this issue
Bug/2035 deploy asset fails if pre existing cbbk dependencies are not also deployed #2051
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue Feb 5, 2025
@JoernBerkefeld
#2035: improved test case for deploying 2 dependent assets
6b5e982
JoernBerkefeld added a commit that referenced this issue Feb 5, 2025
@JoernBerkefeld
#2035 improve code comments
a425c26
@github-actions github-actions bot closed this as completed Feb 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

Closed by #2051.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/asset COMPONENT PRIORITY used for professional service clients
Projects
None yet
Milestone
7.7.0
1 participant
@JoernBerkefeld