Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect behaviour when trying to retrieve/deploy when single child folders are compressed #114

Closed
anasilva105 opened this issue Feb 1, 2024 · 2 comments · Fixed by #165
Assignees
Labels
bug Something isn't working Done In Review NEW not yet analyzed new issues get this label
Milestone

Comments

@anasilva105
Copy link
Collaborator

Describe the bug
When a Business Unit folder has only a single metadata type folder when trying to retrieve another metadata type the extension is not able to detect the Business Unit folder click and will retrieve again the single metadata type that already exists. This is due to the fact that Visual Studio Code has enabled in Settings "Explorer: Compact Folders", making the path retrieve to the only configured folder.

To Reproduce
Steps to reproduce the behavior:

  1. Have a single Business Unit in the retrieve folder
  2. Retrieve only one metadata type. If Compact Folder is enabled the folder will be shown as compacted
  3. Try to retrieve another metadata type by right clicking on the same business unit
  4. Command will run and retrieve the existing metadata type.

Expected behavior
The selection of metadata types popup should be shown everytime the use retrieves/deploys by selecting the Business Unit folder

Screenshots
image

Additional context
Extension should setup in the settings explorer.compactFolders = false

@anasilva105 anasilva105 added bug Something isn't working NEW not yet analyzed new issues get this label labels Feb 1, 2024
@anasilva105 anasilva105 added this to the 1.0.1 milestone Feb 1, 2024
@anasilva105 anasilva105 self-assigned this Feb 1, 2024
@anasilva105 anasilva105 modified the milestones: 1.0.1, 1.0.0 Feb 5, 2024
@JoernBerkefeld
Copy link
Contributor

"Extension should setup in the settings explorer.compactFolders = false"
no it shouldnt. That's a great feature and there might just be a workaround for it.

related issues:

kind of an edge issue: most users wont just retrieve one metadata type but go with default and retrieve all at once. I will therefore go ahead and move it back into milestone 1.0.1.

@JoernBerkefeld JoernBerkefeld modified the milestones: 1.0.0, 1.0.1 Feb 7, 2024
@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Feb 7, 2024

after a quick google search i would suggest opening a bug ticket here: https://github.com/microsoft/vscode/issues/new?assignees=&labels=&projects=&template=bug_report.md

There was an old bug for the same but that was resolved back then: microsoft/vscode#86103

also, maybe a more detailed search with your way of getting the folder path gets us to the finish line. my generic search didn't help. I did successfully reproduce the bug the way you describe it above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Done In Review NEW not yet analyzed new issues get this label
Projects
None yet
2 participants