Skip to content

Commit 89fd37e

Browse files
authored
Add numpy dependency to python wrapper. (#1935)
* update pyproject.toml and python workflows: Add numpy dependency - Additional dependencies required for the build environment Numpy must be installed in the python environment where the build is being performed in order to build. - Automatic installation of dependencies like a normal python package When installing this package, if numpy does not exist in the python environment, it will be installed automatically. Signed-off-by: HyeongSeok Kim <[email protected]> * update python-wheels-*yml, pyproject.toml: remove BEFORE_BUILD, remove numpy in build requires - python-wheels-*yml: When testing on other PRs, I found that dependencies were not properly installed for each build case, so I added this code. However, this PR is for adding numpy dependencies, so it is not needed as @JeanChristopheMorinPerso suggested. - pyproject.toml: If you are going to do any additional work with the build artifacts, like generating stubs, you will need numpy in your build environment, but it is not needed at the moment. I agree with the review by @JeanChristopheMorinPerso. Signed-off-by: HyeongSeok Kim <[email protected]> --------- Signed-off-by: HyeongSeok Kim <[email protected]>
1 parent 867ce30 commit 89fd37e

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,10 @@ build-nuget/
5454
*~
5555
.vscode
5656
docs/_test_images/
57+
dist/*
58+
__pycache__/
59+
*.py[cod]
60+
*$py.class
5761

5862
# Ignore Bazel generated files
5963
bazel-*

pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ authors = [
1616
]
1717
requires-python = ">=3.7"
1818

19+
dependencies = [
20+
"numpy>=1.7.0"
21+
]
22+
1923
[project.urls]
2024
"Homepage" = "https://openexr.com"
2125
"Source" = "https://github.com/AcademySoftwareFoundation/OpenEXR"

0 commit comments

Comments
 (0)