-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What about Windows containers? #70
Comments
The VFX Platform 2021 now specifies versions of Visual Studio and Windows SDK, and I think it would be useful to have Windows build containers. One thing that got lost in the transition of ASWF projects from Azure Pipelines to GitHub Actions is that currently GHA does not support "build inside a container" on Windows runners, hopefully that will show up at some point. I believe that any submissions that would add support for building Windows containers would be welcome. |
Unfortunately I don't think we can make windows containers available for licensing reasons. See https://github.com/conan-io/conan-docker-tools/blob/master/msvc_15/Dockerfile as an example of windows docker recipe that works but cannot be redistributer... |
The MICROSOFT SOFTWARE SUPPLEMENTAL LICENSE FOR WINDOWS CONTAINER BASE IMAGE discusses at length the need for a valid license for the OS running the container (which a GHA Windows runner would have), but I've yet to find an unambiguous reference to the specific case of hosting / redistributing a container image where the base layer is a Windows Container Base Image, or for that matter a container image including an installation of MSVC. So while I think we could add support for building Windows containers similarly to the Linux ones and run test builds, it would be preferable not to publish these build artifacts without specific guidance. Building and pushing Conan Windows packages is probably much more immediately useful anyway. |
Looking at How We Cut Our Docker Push Time by 90%, it seems it may be possible to only push the additional layers to the repository without having to copy the base image (with further possible complication since WIndows Container Base Images now live on mcr.microsoft.com). That wouldn't help to deal with a layer containing the MSVC install, but it might mean you can push a container that only references the official Microsoft containers, not bundle them. Could be also interesting to see if this approach might avoid having to upload the CentOS 7 base layer for Linux containers? |
Hell, even if you don't provide the nicely tagged prebuilt Windows Docker images, if there's a good Dockerfile that one can "docker build" and "it just works", that'd already be a huge improvement over nothingness. 🤷♂️ Then everyone at their own studio can just build it locally and push it to their studio's own private Docker image registry. |
I've started #149 with a working Dockerfile on windows that can already build some conan packages. |
Hey guys,
First of all let me say to anyone involved that you've done an amazing job with these containers and tagging them very well. Kudos! :)
I was wondering if there has been thoughts about providing Windows10 containers for the VFX Platform?
Has anyone started or tried already?
The text was updated successfully, but these errors were encountered: