Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnyDictionary and AnyVector support for V2d and Box2d #1811

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

peter-targett
Copy link
Contributor

@peter-targett peter-targett commented Nov 13, 2024

Fixes #1714

Summarize your change.

Add Imath V2d and Box2d types so they can be added as metadata in AnyDictionary and AnyVector containers.

Reference associated tests.

Add basic tests for V2d and Box2d to serializable object tests. Also, adapt the composable object test, to test metadata serialization.

Signed-off-by: Peter Targett <[email protected]>
Signed-off-by: Peter Targett <[email protected]>
Signed-off-by: Peter Targett <[email protected]>
Signed-off-by: Peter Targett <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.66%. Comparing base (c0e97b0) to head (4ae2fec).
Report is 29 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1811      +/-   ##
==========================================
- Coverage   84.11%   81.66%   -2.46%     
==========================================
  Files         198      176      -22     
  Lines       22241    12679    -9562     
  Branches     4687     2791    -1896     
==========================================
- Hits        18709    10354    -8355     
+ Misses       2610     1786     -824     
+ Partials      922      539     -383     
Flag Coverage Δ
py-unittests 81.66% <100.00%> (-2.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...melineio/opentimelineio-bindings/otio_bindings.cpp 98.47% <100.00%> (+0.11%) ⬆️
...ntimelineio/opentimelineio-bindings/otio_utils.cpp 70.10% <100.00%> (+3.43%) ⬆️
tests/test_composable.py 92.59% <100.00%> (ø)
tests/test_serializable_object.py 93.37% <100.00%> (+0.33%) ⬆️

... and 120 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3e317...4ae2fec. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnyDictionary and AnyVector don't support Box2d and V2d
2 participants