Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timecodes cause issue with RationalTime #336

Closed
alatdneg opened this issue Oct 2, 2018 · 2 comments
Closed

Timecodes cause issue with RationalTime #336

alatdneg opened this issue Oct 2, 2018 · 2 comments

Comments

@alatdneg
Copy link

alatdneg commented Oct 2, 2018

Hiya, I've been playing with timecodes and media references, it was going great until I hit problems with comparing Time/Ranges.

It was going fine until I tried the following.

range_from_start_end_time(from_timecode("01:00:00:00",24.0), from_timecode("01:00:01:00",24.0)).contains(range_from_start_end_time(from_timecode("01:00:00:00",23.976), from_timecode("01:00:01:00",23.976)))
False

I'm wondering how we're meant to deal with this, are using TimeRanges/Rational times as containers for timecodes, is it just a non starter, dues to their odd behavior.

In timecode land 23.976 == 24.0, in RationalTime etc, 23.976 != 24.0.

cheers!

@alatdneg
Copy link
Author

alatdneg commented Oct 3, 2018

This makes me wonder if the EDL reader should set the clip rate to the int value, and use the global_start_time timeline attribute to set the fractional rate.

Does that make sense ?

@jminor
Copy link
Collaborator

jminor commented Nov 15, 2024

Support for timecode rates was improved in this PR: #1477

@meshula meshula closed this as completed Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants