Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flattening tracks sometimes splits contiguous clips into segments #1635

Open
jminor opened this issue Jun 26, 2023 · 7 comments
Open

Flattening tracks sometimes splits contiguous clips into segments #1635

jminor opened this issue Jun 26, 2023 · 7 comments
Labels
bug A problem, flaw, or broken functionality. good first issue If you're looking for a way to contribute, but not sure where to start. This is a good first issue. help wanted We're looking for help from the community - you're weclome to volunteer!

Comments

@jminor
Copy link
Collaborator

jminor commented Jun 26, 2023

Incorrect Functionality

If a track has adjacent Gaps, then items below the boundary between those Gaps are sliced in an unexpected way.

To Reproduce

Using this test file "bug_before_flatten_redacted.otio"...
flatten_bug_repro.zip

Run this command:

% otiotool -i bug_before_flatten_redacted.otio --flatten video -o out.otio

Expected Behavior

Clips below adjacent Gaps should not be segmented by the flatten operation. In the provided example, Clip #1 should be left as-is.

Screenshots

Here is a screenshot before flattening (note the highlighted Gap on the top track)
Screenshot 2023-06-26 at 10 45 25 AM

Here is the result after flattening (note that Clip #1 has been split in two)
Screenshot 2023-06-26 at 10 45 38 AM

@jminor jminor added the bug A problem, flaw, or broken functionality. label Jun 26, 2023
@jminor jminor added help wanted We're looking for help from the community - you're weclome to volunteer! good first issue If you're looking for a way to contribute, but not sure where to start. This is a good first issue. labels Jul 17, 2023
@douglascomet
Copy link
Contributor

Seems related to the behavior outlines in #1430

@praerie
Copy link

praerie commented Sep 13, 2024

hi, I'd like to work on this for DevDays!

@jminor
Copy link
Collaborator Author

jminor commented Sep 13, 2024

That would be great @praerie - let us know if you want any guidance.

@markreidvfx
Copy link
Contributor

Hi @praerie, someone on my team has been looking into this issue (and was kinda hoping to work on it for dev days too) but since you claimed it first, happy to share our findings.

Our initial thought is to combine the time ranges of contiguous non-visibile items before the recursively trimming occurs.

@praerie
Copy link

praerie commented Sep 14, 2024

thank you, @markreidvfx! I would be happy to collaborate if your teammate still wants to work on this.

@rameshbabuvfxtd
Copy link

Hi @praerie, I'm the one looking into this issue. I have an idea for this issue happy to collaborate with you. Thanks for accepting for collaboration.

@talk2mybot
Copy link

Hi all, I'm also interested into collaborating on dev days with you on this project, if thats o'right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem, flaw, or broken functionality. good first issue If you're looking for a way to contribute, but not sure where to start. This is a good first issue. help wanted We're looking for help from the community - you're weclome to volunteer!
Projects
None yet
Development

No branches or pull requests

6 participants