Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDL CMX 3600 Adapter: EDL files with TimeWarp retiming effects do not round trip correctly #1458

Open
ghost-luck opened this issue Oct 17, 2022 · 0 comments · May be fixed by #1459
Open

EDL CMX 3600 Adapter: EDL files with TimeWarp retiming effects do not round trip correctly #1458

ghost-luck opened this issue Oct 17, 2022 · 0 comments · May be fixed by #1459
Labels
bug A problem, flaw, or broken functionality.

Comments

@ghost-luck
Copy link

ghost-luck commented Oct 17, 2022 •
edited
Loading

Bug Report

Incorrect Functionality and General Questions

Reading and writing an EDL file with a TimeWarp retime effect causes differences between the source timecodes.

To Reproduce

Source Out timecode should be 00:32:06:19. But we get 00:32:06:00.

import opentimelineio as otio

edl = "TITLE: TEST_EDL\n" \
      "FCM: NON-DROP FRAME\n" \
      "000001 B113RPTW V C 00:32:02:06 00:32:06:19 01:34:53:09 01:34:57:13\n" \
      "M2 B113RPTW 026.4 00:32:02:06"

in_timeline = otio.adapters.read_from_string(edl,
                                             rate=24.0,
                                             adapter_name="cmx_3600")

out_timeline = otio.adapters.write_to_string(in_timeline,
                                             rate=24.0,
                                             adapter_name="cmx_3600")
print(otio.__version__)
print(out_timeline)

# 0.14.1
# TITLE: TEST_EDL
# 
# 001  B113RPTW V     C        00:32:02:06 00:32:06:00 01:34:53:09 01:34:57:13
# M2   000001		26.4			00:32:02:06
# * FROM CLIP NAME:  000001

Expected Behavior

We should be getting the same source timecodes. Since we did not make any timeline modifications.
@ghost-luck ghost-luck added the bug A problem, flaw, or broken functionality. label Oct 17, 2022
@ssteinbach ssteinbach linked a pull request Oct 18, 2022 that will close this issue
EDL CMX 3600 Adapter: Fix Source Out calculation when a TimeWarp retiming effect is present #1459
Open
@ssteinbach ssteinbach changed the title EDL CMX 3600 Adapter: Bug in EDL → OTIO → EDL round-trip EDL CMX 3600 Adapter: EDL files with TimeWarp retiming effects do not round trip correctly Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A problem, flaw, or broken functionality.
Projects
None yet
Milestone
No milestone
1 participant
@ghost-luck