[BUG] neon support is disabled on macOS arm #3909
Comments
|
You are quite right, that looks wrong. Should be an easy fix, I will prepare a PR right away. |
|
Please see proposed fix in #3911. @1-Olivier can you try that out on your end and verify that it looks right to you? |
|
Looks good and works for me. |
lgritz
added a commit
that referenced
this issue
Jul 17, 2023
Clean up the `#if` tests that disable Intel SIMD when not on Intel architectures, which incorrectly disabled ARM NEON when on ARM. Fixes #3909 Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this issue
Jul 17, 2023
…3911) Clean up the `#if` tests that disable Intel SIMD when not on Intel architectures, which incorrectly disabled ARM NEON when on ARM. Fixes AcademySoftwareFoundation#3909 Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit 22a8196 does
#define OIIO_NO_NEON 1whenever__aarch64__is set so a macOS arm build ends up with no neon support. By the commit message and comments, I don't think that was the intent.Stuff still works. I only found out because I have an assertion in my code that some buffers provided by OSL should be 16 byte aligned and they weren't.
The text was updated successfully, but these errors were encountered: