Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't kill a job from CueGui if running on Windows #1519

Closed
KernAttila opened this issue Sep 29, 2024 · 0 comments · Fixed by #1520
Closed

Can't kill a job from CueGui if running on Windows #1519

KernAttila opened this issue Sep 29, 2024 · 0 comments · Fixed by #1520
Labels
bug Something isn't working

Comments

@KernAttila
Copy link
Contributor

KernAttila commented Sep 29, 2024 •
edited
Loading

Describe the bug
We are unable to "kill" a frame/job from CueGui running on Windows.
os.uname() is not available on Windows, we can safely replace it by platform.uname() (tested on Linux and Windows)

To Reproduce
Steps to reproduce the behavior:

  1. Open CueGui on a Windows host
  2. Kill a frame
  3. AttributeError: module 'os' has no attribute 'uname'.

Expected behavior
Same behavior on Windows and Linux.

Version Number
0.35
@KernAttila KernAttila added the bug Something isn't working label Sep 29, 2024
@KernAttila KernAttila changed the title Can't kill a job from Cuebot if running on Windows Can't kill a job from CueGui if running on Windows Sep 29, 2024
@KernAttila KernAttila mentioned this issue Sep 29, 2024
Merged
DiegoTavares pushed a commit that referenced this issue Oct 1, 2024
@KernAttila
[cuegui] Kill a Job from Windows. (#1520)
8f7f23c 
**Link the Issue(s) this Pull Request is related to.**
Fixes: #1519

**Summarize your change.**
Use `platform.uname()` instead of `os.uname()`. They have the same
result on Linux, but `os.uname()` is not available on Windows, making us
unable to kill a job from this OS.

**Additional information.**
Linux (ubuntu 22.04.6): 
``` python
>>> os.uname()
posix.uname_result(sysname='Linux', nodename='titan', release='6.8.0-45-generic', version='#45~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Sep 11 15:25:05 UTC 2', machine='x86_64')
>>>platform.uname()
uname_result(system='Linux', node='titan', release='6.8.0-45-generic', version='#45~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Sep 11 15:25:05 UTC 2', machine='x86_64')
```
Windows (11): 
``` python
>>> platform.uname()
uname_result(system='Windows', node='StarChaser', release='10', version='10.0.22631', machine='AMD64')
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cuegui] Kill a Job from Windows. KernAttila/OpenCue
1 participant
@KernAttila