Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config's setActiveViews doesn't support views with commas in the name #2086

Open
doug-walker opened this issue Oct 24, 2024 · 0 comments
Open
Labels
Bug Unwanted or incorrect behavior in currently available functionality.

Comments

@doug-walker
Copy link
Collaborator

Commas are used as a separator for the string passed to setActiveViews or received from getActiveViews. If a view name has a comma, it will be treated as a separator and essentially break the config.

When serializing a config file, OCIO uses quotes in the YAML to package certain strings that contain commas, such as color spaces and view transforms. So it is possible to get commas through the YAML parsing. However they are not handled by SplitStringEnvStyle in ParseUtils.cpp which is used to tokenize the string argument to setActiveViews.

The proposal is that SplitStringEnvStyle be upgraded to handle quotes similar to how they work in YAML, as a way to separate string tokens that may contain commas. Similarly, JoinStringEnvStyle should be upgraded to quote names with commas.

A similar problem exists with setActiveDisplays and would be fixed at the same time, since it uses SplitStringEnvStyle.

@doug-walker doug-walker added the Bug Unwanted or incorrect behavior in currently available functionality. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unwanted or incorrect behavior in currently available functionality.
Projects
None yet
Development

No branches or pull requests

1 participant