Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT]: Include HDR Output Transforms in the views list for Display P3 #112

Open
nick-shaw opened this issue Sep 19, 2023 · 5 comments
Labels
configs for separation purposes enhancement New feature or request

Comments

@nick-shaw
Copy link

Apple kCGColorSpaceExtendedDisplayP3 supports float values above 1.0 for HDR/EDR display on capable Mac systems. Currently the views for the newly added Display P3 display in the Studio and CG configs only include the SDR D65 and D60 sim Output Transforms. The addition of HDR Output transforms to that list would greatly simplify working in HDR for users with suitable Apple devices.

I have previously made my own config which does exactly this, and in my (admittedly limited) testing there appear to be no issues with mixing SDR and HDR views for the same display.

@KelSolaar
Copy link
Contributor

Hey @nick-shaw,

Thanks! The starting point is to have the corresponding Output Transform on the aces-dev side like I did for the SDR variant. Once this is done, we can start looking at adding it to the config.

Cheers,

@nick-shaw
Copy link
Author

Thanks @KelSolaar

So is it the case that the config must have a 1:1 relationship with Output Transforms in aces-dev? I was imagining that given the separation of views and displays in OCIO, it would only be necessary to add to the Display P3 views list, to indicate that (on suitable devices) it was capable of showing HDR as well as SDR view transforms. Probably only ACES 1.1 - HDR Video (1000 nits & P3 lim).

@KelSolaar
Copy link
Contributor

Yes, we derive the Reference transforms to build from aces-dev and use a spreadsheet that links a given ACEStransformID to the relevant OCIO BuiltinTransform and Display Colorspace: https://docs.google.com/spreadsheets/d/1SXPt-USy3HlV2G2qAvh9zit6ZCINDOlfKT07yXJdWLg/edit#gid=0

@nick-shaw
Copy link
Author

This commit adds Display P3 1000 nit forward and inverse Output Transforms. But it is not clear to me what the file names and transform IDs should be.

Thoughts?

Tagging @scottdyer and @aforsythe.

@KelSolaar KelSolaar changed the title (enhancement): Include HDR Output Transforms in the views list for Display P3 [ENHANCEMENT]: Include HDR Output Transforms in the views list for Display P3 Oct 2, 2023
@carolalynn carolalynn added the configs for separation purposes label Nov 2, 2023
@doug-walker doug-walker added the enhancement New feature or request label Jul 20, 2024
@doug-walker
Copy link
Contributor

This would require a separate display rather than overloading the existing SDR Display P3. Apple has an extended Display P3 color space, so perhaps that could inform the name. It needs to be clear whether a display is either an SDR or HDR target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configs for separation purposes enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants