Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce GH actions for version tag check and release notes presence #71

Merged

Conversation

MobiTikula
Copy link
Collaborator

@MobiTikula MobiTikula commented Nov 19, 2024

Release Notes:

  • Switched to use new GH action. Simplified workflow files.

Closes #70

@MobiTikula MobiTikula self-assigned this Nov 19, 2024
@MobiTikula MobiTikula linked an issue Nov 19, 2024 that may be closed by this pull request
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code review

.github/workflows/release_notes_comments_migration.yml Outdated Show resolved Hide resolved
@@ -14,7 +14,7 @@
# limitations under the License.
#

# GH workflow example from https://github.com/AbsaOSS/generate-release-notes/blob/master/examples/release_draft.yml
# GH workflow source https://github.com/AbsaOSS/generate-release-notes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# GH workflow source https://github.com/AbsaOSS/generate-release-notes
# GH workflow source https://github.com/AbsaOSS/generate-release-notes/blob/master/.github/workflows/release_draft.yml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -14,7 +14,7 @@
# limitations under the License.
#

# GH workflow example from https://github.com/AbsaOSS/generate-release-notes/blob/master/examples/check_pr_release_notes.yml
# GH workflow source https://github.com/AbsaOSS/release-notes-presence-check
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# GH workflow source https://github.com/AbsaOSS/release-notes-presence-check
# GH workflow source https://github.com/AbsaOSS/generate-release-notes/blob/master/.github/workflows/check_pr_release_notes.yml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MobiTikula MobiTikula merged commit c6a1600 into master Nov 19, 2024
4 checks passed
@MobiTikula MobiTikula deleted the feature/70-Simplify-GH-Workflows-using-new-GH-Actions branch November 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify GH Workflows using new GH Actions
2 participants