Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#110 - Introduce GH actions for version tag check and release notes presence #111

Merged
merged 8 commits into from
Nov 19, 2024
Merged

#110 - Introduce GH actions for version tag check and release notes presence #111

merged 8 commits into from
Nov 19, 2024

Conversation

miroslavpojer
Copy link
Collaborator

@miroslavpojer miroslavpojer commented Nov 18, 2024 •
edited
Loading

Release Notes:

  • Switched to use new GH action. Simplified workflow files.

Closes #110

@miroslavpojer
#110 - Introduce GH actions for version tag check and release notes p…
2a9dea9 
…resence

- Switched to use new GH action. Simplified workflow files.
@miroslavpojer miroslavpojer added the work in progress Work on this item is not yet finished (mainly intended for PRs) label Nov 18, 2024
@miroslavpojer miroslavpojer self-assigned this Nov 18, 2024
MobiTikula
MobiTikula reviewed Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check can be skipped by using the skip-release-notes label.

I would add extra sentence about how to use it. It is little confusing, since it is not bool but people can write something as a string.

examples/check_pr_release_notes.yml
@@ -14,61 +14,14 @@ jobs:
runs-on: {your-runner}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a comment here, so it highlights where user is supposed to make a change. Should do the same change in other example.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@miroslavpojer miroslavpojer merged commit 66e52bd into master Nov 19, 2024
4 checks passed
@miroslavpojer miroslavpojer deleted the feature/110-Introduce-GH-actions-for-version-tag-check-and-release-notes-presence branch November 19, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MobiTikula MobiTikula MobiTikula approved these changes

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@benedeki benedeki Awaiting requested review from benedeki

Assignees

@miroslavpojer miroslavpojer

Labels
work in progress Work on this item is not yet finished (mainly intended for PRs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce GH actions for version tag check and release notes presence
2 participants
@miroslavpojer @MobiTikula