Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type used in chapters definition #85

Open
miroslavpojer opened this issue Oct 9, 2024 · 0 comments
Open

Wrong type used in chapters definition #85

miroslavpojer opened this issue Oct 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@miroslavpojer
Copy link
Collaborator

miroslavpojer commented Oct 9, 2024

Describe the bug

The release notes generator seems to expect string in the array of chapters definition.

Expected behavior

Use proper "strong" type - yaml does support arrays.

Example

See in here:

          chapters: '[
            {"title": "Breaking Changes 💥", "label": "breaking-change"},
            {"title": "New Features 🎉", "label": "enhancement"},
            {"title": "New Features 🎉", "label": "feature"},
            {"title": "Bugfixes 🛠", "label": "bug"}
          ]'

Expected format

          chapters: [
            {"title": "Breaking Changes 💥", "label": "breaking-change"},
            {"title": "New Features 🎉", "label": "enhancement"},
            {"title": "New Features 🎉", "label": "feature"},
            {"title": "Bugfixes 🛠", "label": "bug"}
          ]
@miroslavpojer miroslavpojer added the bug Something isn't working label Oct 9, 2024
@benedeki benedeki changed the title Bug: wrong type inout in chapters Wrong type inout in chapters Oct 9, 2024
@benedeki benedeki changed the title Wrong type inout in chapters Wrong type used in chapters definition Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant