Skip to content

Commit 29c5e32

Browse files
committed
* fixed missing version in get_schema.sql
* added disabled flag in return of list_schemas.sql
1 parent fefd5f3 commit 29c5e32

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

database/src/main/dataset_schema/get_schema.sql

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
* limitations under the License.
1414
*/
1515

16-
DROP FUNCTION dataset_schema.get_schema(TEXT, INTEGER);
17-
DROP FUNCTION dataset_schema.get_schema(BIGINT);
16+
DROP FUNCTION IF EXISTS dataset_schema.get_schema(TEXT, INTEGER);
17+
DROP FUNCTION IF EXISTS dataset_schema.get_schema(BIGINT);
1818

1919
CREATE OR REPLACE FUNCTION dataset_schema.get_schema(
2020
IN i_schema_name TEXT,
@@ -91,14 +91,14 @@ BEGIN
9191
RETURN;
9292
END IF;
9393

94-
SELECT 200, 'OK', dss.id_schema, dss.schema_name,
94+
SELECT 200, 'OK', dss.id_schema, dss.schema_name, dss.schema_version,
9595
dss.schema_description, dss.fields, _created_by, _created_when,
9696
dss.updated_by, dss.updated_when, _locked_by, _locked_when,
9797
_disabled_by, _disabled_when
9898
FROM dataset_schema.schemas dss
9999
WHERE dss.schema_name = i_schema_name AND
100100
dss.schema_version = _schema_version
101-
INTO status, status_text, id_schema, schema_name,
101+
INTO status, status_text, id_schema, schema_name, schema_version,
102102
schema_description, fields, created_by, created_when,
103103
updated_by, updated_when, locked_by, locked_when,
104104
disabled_by, disabled_when;
@@ -168,11 +168,11 @@ DECLARE
168168
_schema_name TEXT;
169169
BEGIN
170170

171-
SELECT 200, 'OK', dss.id_schema, dss.schema_name,
171+
SELECT 200, 'OK', dss.id_schema, dss.schema_name, dss.schema_version,
172172
dss.schema_description, dss.fields, dss.updated_by, dss.updated_when
173173
FROM dataset_schema.schemas dss
174174
WHERE dss.id_schema = i_key_schema
175-
INTO status, status_text, id_schema, _schema_name,
175+
INTO status, status_text, id_schema, _schema_name, schema_version,
176176
schema_description, fields, updated_by, updated_when;
177177

178178
IF NOT found THEN
@@ -189,7 +189,7 @@ BEGIN
189189
INTO created_by, created_when, locked_by, locked_when,
190190
disabled_by, disabled_when;
191191

192-
schema_name := _schema_name; -- used a local variable to avoid name disambiguaty
192+
schema_name := _schema_name; -- used a local variable to avoid name disambiguity
193193

194194
RETURN;
195195
END;

database/src/main/dataset_schema/list_schemas.sql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ DROP FUNCTION IF EXISTS dataset_schema.list_schemas(BOOLEAN);
1818
CREATE OR REPLACE FUNCTION dataset_schema.list_schemas(
1919
IN i_include_disabled BOOLEAN DEFAULT FALSE,
2020
OUT schema_name TEXT,
21-
OUT schema_latest_version INTEGER
21+
OUT schema_latest_version INTEGER,
22+
OUT disabled BOOLEAN
2223
) RETURNS SETOF record AS
2324
$$
2425
-------------------------------------------------------------------------------
@@ -37,7 +38,7 @@ $$
3738
DECLARE
3839
BEGIN
3940
RETURN QUERY
40-
SELECT dsh.schema_name, dsh.schema_latest_version
41+
SELECT dsh.schema_name, dsh.schema_latest_version, dsh.disabled_when IS NOT NULL
4142
FROM dataset_schema.heads dsh
4243
WHERE i_include_disabled OR dsh.disabled_when IS NULL
4344
ORDER BY schema_name; --TODO Include order by?

0 commit comments

Comments
 (0)