Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#291: Project improvements after 0.3.0 release #300

Merged
merged 11 commits into from
Nov 22, 2024
Merged

#291: Project improvements after 0.3.0 release #300

merged 11 commits into from
Nov 22, 2024

Conversation

benedeki
Copy link
Contributor

@benedeki benedeki commented Nov 7, 2024 •
edited
Loading

  • set credentials persistence to false in GitHub checkout actions
  • fixed release notes presence check GitHub workflow
  • added supported Atum Agent control functions list to documentation
  • added new grouping of issues into release notes draft
  • added badges to README.md
  • conditional load of some modules based on Java version
  • Tests are run on all versions of Scala

Closes #291

Release Notes:

  • Documentation enhanced including the list of control functions Atum currently supports

@benedeki
#291: Project improvements after 0.3.0 release
2280d7d 
* set credentials persistence to `false` in GitHub checkout actions
* fixed release notes presence check GitHub workflow
* added supported Atum Agent control functions list to documentation
* added new grouping of issues into release notes draft
* added badges to `README.md`
@benedeki benedeki added documentation Improvements or additions to documentation infrastructure Project setup and deployment labels Nov 7, 2024
@benedeki benedeki self-assigned this Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

JaCoCo model module code coverage report - scala 2.13.11

Overall Project 59.69% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project 78.49% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

JaCoCo reader module code coverage report - scala 2.13.11

Overall Project 100% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 68.89% 🍏

There is no coverage information present for the Files changed

lsulak
lsulak reviewed Nov 8, 2024
View reviewed changes
README.md
@@ -1,6 +1,19 @@
# Atum Service

[![Build](https://github.com/AbsaOSS/spark-commons/actions/workflows/build.yml/badge.svg)](https://github.com/AbsaOSS/spark-commons/actions/workflows/build.yml)
[![License](http://img.shields.io/:license-apache-blue.svg)](http://www.apache.org/licenses/LICENSE-2.0.html)
[![Maintenance](https://img.shields.io/badge/Maintained%3F-yes-green.svg)](https://GitHub.com/Naereen/StrapDown.js/graphs/commit-activity)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful!

lsulak
lsulak reviewed Nov 8, 2024
View reviewed changes
README.md Outdated

The purpose of Atum is to provide means of ensuring no critical fields have been modified during
the processing and no records are added or lost. To do this the library provides an ability
to calculate *hash sums* of explicitly specified columns. We call the set of hash sums at a given time
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to explicitly word it like this, hash sums? I think if we are talking about a general measurement perhaps hash sum is a bit too specific / a bit misleading?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good text otherwise!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Henestly I didn't write it. I just copied it from Atum and adjusted the function name. It's because last time Manny asked about the supported functions and I found out we don't have them, but old Atum has.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh okay. No worries. But perhaps still, consider changing it

lsulak
lsulak reviewed Nov 8, 2024
View reviewed changes
README.md Show resolved Hide resolved
miroslavpojer
miroslavpojer reviewed Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the improvement. I see a lot of TBD. Are they planned to be one in this PR?

@benedeki
Copy link
Contributor Author

I like the improvement. I see a lot of TBD. Are they planned to be one in this PR?

Nope. This was intended to be a small PR, it already covers more things...

@benedeki benedeki added the work in progress Work on this item is not yet finished (mainly intended for PRs) label Nov 18, 2024
@benedeki benedeki removed the work in progress Work on this item is not yet finished (mainly intended for PRs) label Nov 21, 2024
@benedeki benedeki mentioned this pull request Nov 21, 2024
Open
lsulak
lsulak reviewed Nov 21, 2024
View reviewed changes
project/Setup.scala Outdated Show resolved Hide resolved
@benedeki benedeki merged commit 5491e5c into master Nov 22, 2024
9 checks passed
@benedeki benedeki deleted the feature/291-project-improvements-after-0.3.0-release branch November 22, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miroslavpojer miroslavpojer miroslavpojer left review comments

@lsulak lsulak lsulak approved these changes

@TebaleloS TebaleloS Awaiting requested review from TebaleloS

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

@salamonpavel salamonpavel Awaiting requested review from salamonpavel salamonpavel is a code owner

@ABLL526 ABLL526 Awaiting requested review from ABLL526 ABLL526 is a code owner

Assignees

@benedeki benedeki

Labels
documentation Improvements or additions to documentation infrastructure Project setup and deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project improvements after 0.3.0 release
3 participants
@benedeki @lsulak @miroslavpojer