* Fix multiline strings review note.

* Fix not used method parameters review note.

Author: miroslavpojer

testApi/src/main/scala/africa/absa/testing/scapi/rest/request/sender/ScAPIRequestSender.scala

@@ -26,7 +26,7 @@ import java.net.HttpCookie
  */
 object ScAPIRequestSender extends RequestSender {
 
-  private def sendRequest(requestFunc: => requests.Response, url: String, headers: Map[String, String], verifySslCerts: Boolean, data: String, params: Map[String, String]): Response = {
+  private def sendRequest(requestFunc: => requests.Response): Response = {
     val startTime = System.nanoTime()
     val response = requestFunc
     val endTime = System.nanoTime()
@@ -58,7 +58,7 @@ object ScAPIRequestSender extends RequestSender {
    * @return Response Returns the response from the GET request.
    */
   override def get(url: String, headers: Map[String, String], verifySslCerts: Boolean, data: String, params: Map[String, String]): Response = {
-    sendRequest(requests.get(url = url, headers = headers, verifySslCerts = verifySslCerts, data = data, params = params), url, headers, verifySslCerts, data, params)
+    sendRequest(requests.get(url = url, headers = headers, verifySslCerts = verifySslCerts, data = data, params = params))
   }
 
   /**
@@ -72,7 +72,7 @@ object ScAPIRequestSender extends RequestSender {
    * @return Response Returns the response from the POST request.
    */
   override def post(url: String, headers: Map[String, String], verifySslCerts: Boolean, data: String, params: Map[String, String]): Response = {
-    sendRequest(requests.post(url = url, headers = headers, verifySslCerts = verifySslCerts, data = data, params = params), url, headers, verifySslCerts, data, params)
+    sendRequest(requests.post(url = url, headers = headers, verifySslCerts = verifySslCerts, data = data, params = params))
   }
 
   /**
@@ -86,7 +86,7 @@ object ScAPIRequestSender extends RequestSender {
    * @return Response Returns the response from the PUT request.
    */
   override def put(url: String, headers: Map[String, String], verifySslCerts: Boolean, data: String, params: Map[String, String]): Response = {
-    sendRequest(requests.put(url = url, headers = headers, verifySslCerts = verifySslCerts, data = data, params = params), url, headers, verifySslCerts, data, params)
+    sendRequest(requests.put(url = url, headers = headers, verifySslCerts = verifySslCerts, data = data, params = params))
   }
 
   /**
@@ -100,6 +100,6 @@ object ScAPIRequestSender extends RequestSender {
    * @return Response Returns the response from the DELETE request.
    */
   override def delete(url: String, headers: Map[String, String], verifySslCerts: Boolean, data: String, params: Map[String, String]): Response = {
-    sendRequest(requests.delete(url = url, headers = headers, verifySslCerts = verifySslCerts, data = data, params = params), url, headers, verifySslCerts, data, params)
+    sendRequest(requests.delete(url = url, headers = headers, verifySslCerts = verifySslCerts, data = data, params = params))
   }
 }

testApi/src/main/scala/africa/absa/testing/scapi/rest/response/Response.scala

@@ -60,7 +60,15 @@ object Response {
   def perform(response: Response, responseAction: Seq[ResponseAction]): Boolean = {
     def logParameters(response: Response, resolvedResponseAction: ResponseAction, exception: Option[Throwable] = None): Unit = {
       val filteredParams = resolvedResponseAction.params.filter(_._1 != "method").map { case (k, v) => s"$k->$v" }.mkString(", ")
-      val baseLog = s"\nParameters received: \n\tRequired Response-Action: \n\t\tGroup->'${resolvedResponseAction.group}', \n\t\tMethod->'${resolvedResponseAction.name}', \n\t\tParams->'${filteredParams}', \n\tActual Response: \n\t\t$response"
+      val baseLog =
+        s"""
+           |Parameters received:
+           |  Required Response-Action:
+           |    Group->'${resolvedResponseAction.group}',
+           |    Method->'${resolvedResponseAction.name}',
+           |    Params->'${filteredParams}',
+           |  Actual Response:
+           |    $response""".stripMargin
       val exceptionLog = exception.map(e => s"\nException: ${e.getMessage}").getOrElse("")
       Logger.debug(s"Response-${resolvedResponseAction.group}: '${resolvedResponseAction.name}' - error details:$baseLog$exceptionLog")
     }