Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#17 resource handling helper classes #18

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

ABMC831
Copy link
Collaborator

@ABMC831 ABMC831 commented Oct 4, 2024

Simplified examples to put more stress on what is part of config and what part of usage

Implemented custom resource handler

Added (commented-out) invocation in scala 3 environment (with scala provided resource handler)

closes #17

@ABMC831 ABMC831 self-assigned this Oct 4, 2024
Copy link
Collaborator

@OlivieFranklova OlivieFranklova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please extend README.md with some guidelines that describe how to run files in the example module and how to use the library, or provide a better description of what and how it's used in example files?

@ABMC831
Copy link
Collaborator Author

ABMC831 commented Oct 8, 2024

Could you please extend README.md with some guidelines that describe how to run files in the example module and how to use the library, or provide a better description of what and how it's used in example files?

to run files in example... well... you run example.....
to have some description in readme... well why not... but probably as separate issue, or do you think it belongs to this PR

@OlivieFranklova
Copy link
Collaborator

Could you please extend README.md with some guidelines that describe how to run files in the example module and how to use the library, or provide a better description of what and how it's used in example files?

to run files in example... well... you run example.....
to have some description in readme... well why not... but probably as separate issue, or do you think it belongs to this PR

It should be a new issue, it could be solved in this one #21

@ABMC831 ABMC831 force-pushed the feature/#17-Resource-handling-helper-classes branch from 912085c to 7b11e9d Compare October 8, 2024 14:00
@ABMC831 ABMC831 merged commit fa69632 into master Oct 10, 2024
1 check passed
@ABMC831 ABMC831 deleted the feature/#17-Resource-handling-helper-classes branch October 10, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource handling helper classes
3 participants