goodbye travis (#38)

Author: michaelwittig

.github/workflows/ci.yml

@@ -0,0 +1,30 @@
+name: CI
+
+on: push
+
+jobs:
+  build:
+    runs-on: 'ubuntu-latest'
+
+    steps:
+
+    - uses: 'actions/checkout@v2'
+
+    - uses: 'actions/setup-python@v2'
+      with:
+        python-version: '3.8'
+
+    - name: yamlllint
+      run: |
+        pip install yamllint==1.24.2
+        find . -type f \( -name '*.yml' -o -name '*.yaml' \) -a ! -name '.*' | while read file; do set -ex && yamllint "$file"; done;
+
+    - name: cfn-lint
+      run: |
+        pip install cfn-lint==0.34.0
+        cfn-lint -i W2501 W4002 -t **/*.yaml
+
+    - name: license
+      run: |
+        sudo apt-get install -y shellcheck
+        find . -type f -name '*.sh' | while read file; do set -ex && shellcheck -s bash "$file"; done

.travis.yml

@@ -141,7 +141,7 @@ Resources:
     Properties:
       HealthCheckIntervalSeconds: 5
       HealthCheckPath: '/'
-      HealthCheckPort: 80
+      HealthCheckPort: '80'
       HealthCheckProtocol: HTTP
       HealthCheckTimeoutSeconds: 3
       HealthyThresholdCount: 2
@@ -189,7 +189,7 @@ Resources:
     Type: 'AWS::RDS::DBInstance'
     DeletionPolicy: Delete # For AWS::RDS::DBInstance resources that don't specify the DBClusterIdentifier property, the default policy is Snapshot which can cause unwanted costs. However, for production setups, we highly recommend to stay with the default to avoid data loss.
     Properties:
-      AllocatedStorage: 5
+      AllocatedStorage: '5'
       BackupRetentionPeriod: 0
       DBInstanceClass: 'db.t2.micro'
       DBName: wordpress
@@ -253,7 +253,7 @@ Resources:
               httpd24: []
           files:
             '/etc/httpd/conf.d/wordpress.conf':
-              content: !Sub |
+              content: |
                 <Directory "/var/www/html">
                 Options Indexes FollowSymLinks
                 AllowOverride All
@@ -317,10 +317,9 @@ Resources:
       TargetGroupARNs:
       - !Ref LoadBalancerTargetGroup
       LaunchConfigurationName: !Ref LaunchConfiguration
-      MinSize: 2
-      MaxSize: 4
-      DesiredCapacity: 2
-      Cooldown: 60
+      MinSize: '2'
+      MaxSize: '4'
+      Cooldown: '60'
       HealthCheckGracePeriod: 300
       HealthCheckType: ELB
       VPCZoneIdentifier:

chapter02/template.yaml

@@ -56,8 +56,8 @@ Resources:
       # allowing inbound ICMP traffic
       SecurityGroupIngress:
       - IpProtocol: icmp
-        FromPort: '-1'
-        ToPort: '-1'
+        FromPort: -1
+        ToPort: -1
         CidrIp: '0.0.0.0/0'
   Instance:
     Type: 'AWS::EC2::Instance'

chapter06/firewall2.yaml

@@ -56,13 +56,13 @@ Resources:
       # allowing inbound ICMP traffic
       SecurityGroupIngress:
       - IpProtocol: icmp
-        FromPort: '-1'
-        ToPort: '-1'
+        FromPort: -1
+        ToPort: -1
         CidrIp: '0.0.0.0/0'
       # allowing inbound SSH traffic
       - IpProtocol: tcp
-        FromPort: '22'
-        ToPort: '22'
+        FromPort: 22
+        ToPort: 22
         CidrIp: '0.0.0.0/0'
   Instance:
     Type: 'AWS::EC2::Instance'

chapter06/firewall3.yaml

@@ -61,13 +61,13 @@ Resources:
       # allowing inbound ICMP traffic
       SecurityGroupIngress:
       - IpProtocol: icmp
-        FromPort: '-1'
-        ToPort: '-1'
+        FromPort: -1
+        ToPort: -1
         CidrIp: '0.0.0.0/0'
       # allowing inbound SSH traffic
       - IpProtocol: tcp
-        FromPort: '22'
-        ToPort: '22'
+        FromPort: 22
+        ToPort: 22
         CidrIp: !Sub '${IpForSSH}/32'
   Instance:
     Type: 'AWS::EC2::Instance'

chapter06/firewall4.yaml

@@ -57,12 +57,12 @@ Resources:
       VpcId: !Ref VPC
       SecurityGroupIngress:
       - IpProtocol: icmp
-        FromPort: "-1"
-        ToPort: "-1"
+        FromPort: -1
+        ToPort: -1
         CidrIp: '0.0.0.0/0'
       - IpProtocol: tcp
-        FromPort: '22'
-        ToPort: '22'
+        FromPort: 22
+        ToPort: 22
         CidrIp: !Sub '${IpForSSH}/32'
       Tags:
       - Key: Name
@@ -74,8 +74,8 @@ Resources:
       VpcId: !Ref VPC
       SecurityGroupIngress:
       - IpProtocol: tcp
-        FromPort: '22'
-        ToPort: '22'
+        FromPort: 22
+        ToPort: 22
         SourceSecurityGroupId: !Ref SecurityGroupBastionHost
       Tags:
       - Key: Name