Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how we store the outcome of the game #845

Open
Debilski opened this issue Jan 31, 2025 · 1 comment
Open

Improve how we store the outcome of the game #845

Debilski opened this issue Jan 31, 2025 · 1 comment

Comments

@Debilski
Copy link
Member

Debilski commented Jan 31, 2025

We currently store the outcome of the game in two variables: gamestate['gameover'] and gamestate['whowins']. With gamestate['whowins'] == 2 signifying a draw. This is somewhat messy and cannot account for additional states. Most importantly, fixing #778 will introduce an additional state: ‘Could not start game’, which for example occurs when either one of the players could not connect. These games should not be counted as a winning condition for the non-failing team, so it makes sense to tell the CI or tournament to either ignore or attempt a replay.

@Debilski
Copy link
Member Author

See pelita/viewer.py::ResultPrinter for how the current logic is being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant