more testing

Author: acabarbaye

utils/filesystem/filepath.go

@@ -31,6 +31,13 @@ func FilePathParentsOnFilesystem(fs FS, fp string) (parents []string) {
 		return
 	}
 	path := elements[0]
+	if path == "" {
+		elements = elements[1:]
+		if len(elements) <= 1 {
+			return
+		}
+		path = elements[0]
+	}
 	parents = append(parents, path)
 	for i := 1; i < len(elements)-1; i++ {
 		path = strings.Join([]string{path, elements[i]}, string(fs.PathSeparator()))

utils/filesystem/filepath_test.go

@@ -12,6 +12,7 @@ import (
 
 	"github.com/ARM-software/golang-utils/utils/commonerrors"
 	"github.com/ARM-software/golang-utils/utils/commonerrors/errortest"
+	"github.com/ARM-software/golang-utils/utils/platform"
 )
 
 func TestFilepathStem(t *testing.T) {
@@ -30,24 +31,52 @@ func TestFilepathStem(t *testing.T) {
 }
 
 func TestFilepathParents(t *testing.T) {
-
-	tests := []struct {
+	type PathTest struct {
 		path            string
 		expectedParents []string
-	}{
+	}
+	tests := []PathTest{
 		{},
 		{
 			path:            "                             ",
 			expectedParents: nil,
 		},
+		{
+			path:            "/",
+			expectedParents: nil,
+		},
+		{
+			path:            ".",
+			expectedParents: nil,
+		},
+		{
+			path:            "./",
+			expectedParents: nil,
+		},
+		{
+			path:            "./blah",
+			expectedParents: []string{"."},
+		},
 		{
 			path:            filepath.Join("a", "great", "fake", "path", "blah"),
 			expectedParents: []string{"a", filepath.Join("a", "great"), filepath.Join("a", "great", "fake"), filepath.Join("a", "great", "fake", "path")},
 		},
 		{
+			path:            "/foo/bar/setup.py",
+			expectedParents: []string{`foo`, filepath.Join(`foo`, `bar`)},
+		},
+	}
+
+	if platform.IsWindows() {
+		tests = append(tests, PathTest{
 			path:            "C:/foo/bar/setup.py",
 			expectedParents: []string{"C:", filepath.Join(`C:`, `\foo`), filepath.Join(`C:`, `\foo`, `bar`)},
-		},
+		})
+	} else {
+		tests = append(tests, PathTest{
+			path:            "C:/foo/bar/setup.py",
+			expectedParents: []string{"C:", filepath.Join(`C:`, `foo`), filepath.Join(`C:`, `foo`, `bar`)},
+		})
 	}
 	for _, tt := range tests {
 		t.Run(tt.path, func(t *testing.T) {