Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acs_common.h has unneeded defines TEST_NAME and TEST_NAME_HELPER #432

Open
cdwilde opened this issue Feb 5, 2025 · 0 comments
Open

acs_common.h has unneeded defines TEST_NAME and TEST_NAME_HELPER #432

cdwilde opened this issue Feb 5, 2025 · 0 comments

Comments

@cdwilde
Copy link

cdwilde commented Feb 5, 2025

In val/common/include/acs_common.h, there is a generic define:

#define TEST_NAME_HELPER(x,y) c##x##y
#define TEST_NAME(x,y) TEST_NAME_HELPER(x,y)

Grepping through the ACS database, I don't see it used anywhere.

We ran into a problem where it conflicted with something local.

Can we either remove it (since it isn't used) or change it to BSA_TEST_NAME_HELPER and BSA_TEST_NAME?

@cdwilde cdwilde changed the title acs_common.h has an unneeded defines TEST_NAME and TEST_NAME_HELPER acs_common.h has unneeded defines TEST_NAME and TEST_NAME_HELPER Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant