Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing defined (__ARM_FEATURE_CMSE) in some cases #171

Open
CanastraRF opened this issue Jun 4, 2024 · 3 comments
Open

missing defined (__ARM_FEATURE_CMSE) in some cases #171

CanastraRF opened this issue Jun 4, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@CanastraRF
Copy link

Hi
most check for __ARM_FEATURE_CMSE are like this
defined (__ARM_FEATURE_CMSE) && (__ARM_FEATURE_CMSE == 3U)
but in some lines are only
(__ARM_FEATURE_CMSE < 3U)
so my tools reporting, that __ARM_FEATURE_CMSE can be undefined and interpreting as 0

please add everywhere a defined (__ARM_FEATURE_CMSE)

compare cmsis_armclang.h with cmsis_gcc.h

@JonatanAntoni JonatanAntoni added the bug Something isn't working label Jun 5, 2024
@JonatanAntoni
Copy link
Member

Hi @CanastraRF, thanks for raising this. Would you be able to provide the required changes as a pull-request to speed up things?

ghost pushed a commit that referenced this issue Jun 20, 2024
@ghost
Copy link

ghost commented Jun 20, 2024

Hello @CanastraRF, can you please check PR #177 if this solves your issue?

@CanastraRF
Copy link
Author

Hello
I've checked PR #177 and for us it is a good solution

ghost pushed a commit that referenced this issue Jun 20, 2024
Check if macro __ARM_FEATURE_CMSE is defined before evaluating it's
value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants