Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testFiles/Link-U/kimono*.avif files to make them spec compliant #199

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update testFiles/Link-U/kimono*.avif files to make them spec compliant #199

wants to merge 2 commits into from

Conversation

leo-barnes
Copy link
Collaborator

Changes done:

  1. Change order of item property associations to place ispe first
  2. Add colr-nclx box with values 1,13,9,0 since this is what Sequence Header says
  3. Strip out optional config OBUs from av1C

Fixes #178

@leo-barnes
Update testFiles/Link-U/kimono*.avif files to make them spec compliant
b61844f 
Changes done:
1. Change order of item property associations to place ispe first
2. Add colr-nclx box with values 1,13,9,0 since this is what Sequence Header says
3. Strip out optional config OBUs from av1C
@leo-barnes
Copy link
Collaborator Author

@ledyba-z
Can't add you as a reviewer. Mind taking a look?

@ledyba-z
Copy link
Contributor

@leo-barnes Thank you so much!
I will take a look in this weekend. Please wait a moment.
(I leave Link-U, and currently I am committing AVIF as a volunteer)

@leo-barnes
Copy link
Collaborator Author

Removed fixes for kimono*.crop.avif since those will get a more complete fix in #202

@leo-barnes
Copy link
Collaborator Author

@y-guyon @wantehchang
Do either of you want to sanity check the files? If not I'll merge this PR.

@y-guyon
Copy link
Collaborator

y-guyon commented Aug 21, 2024 •
edited
Loading

I ran avifdec at AOMediaCodec/libavif@3e4b9c8 compiled with

    "AVIF_ENABLE_EXPERIMENTAL_YCGCO_R": "ON",
    "AVIF_ENABLE_EXPERIMENTAL_GAIN_MAP": "ON",
    "AVIF_ENABLE_EXPERIMENTAL_MINI": "ON",
    "AVIF_ENABLE_EXPERIMENTAL_SAMPLE_TRANSFORM": "ON",

on all kimono*.avif and it only fails on kimono.crop.avif and kimono.mirror-vertical.rotate270.crop.avif with the error:

ERROR: Failed to parse image: BMFF parsing failed
Diagnostics:
 * [Strict] calculated crop X offset 543/2 is not an integer

which looks unrelated to this PR.

@leo-barnes
Copy link
Collaborator Author

I ran avifdec on all kimono*.avif and it only fails on kimono.crop.avif and kimono.mirror-vertical.rotate270.crop.avif with the error:

ERROR: Failed to parse image: BMFF parsing failed
Diagnostics:
 * [Strict] calculated crop X offset 543/2 is not an integer

which looks unrelated to this PR.

Hmmm... I'll take a look at that, we ideally want all conformance files to actually make sense.

@baumanj
Copy link
Collaborator

baumanj commented Aug 21, 2024

FYI #150 can be closed when those files get fixed up

@podborski podborski added the conformance Related to conformance suite. E.g. file updates, asserts, etc. label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantehchang wantehchang Awaiting requested review from wantehchang

@baumanj baumanj Awaiting requested review from baumanj

@y-guyon y-guyon Awaiting requested review from y-guyon

Assignees
No one assigned
Labels
conformance Related to conformance suite. E.g. file updates, asserts, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid test files: transforms before ImageSpatialExtentsProperty (ispe)
5 participants
@leo-barnes @ledyba-z @y-guyon @baumanj @podborski