Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make integration.type parsing conditional on TimeIntegratorOption #20

Open
jackieyao0114 opened this issue Apr 26, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@jackieyao0114
Copy link
Collaborator

Right now integration.type is mandatory for all values of TimeIntegratorOption.
However, integration.type is only needed for TimeIntegratorOption = 4, not for TimeIntegratorOption = 0; 1; 2; 3.
We should find a way to change the parsing conditional, i.e. integration.type is still mandatory (parsed by get function) when TimeIntegratorOption = 4, but is not required when TimeIntegratorOption = 0; 1; 2; 3. Better off, when TimeIntegratorOption = 0; 1; 2; 3 but there is some integration.type value provided by the input, the code should generate a warning.

@jackieyao0114 jackieyao0114 added the enhancement New feature or request label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant