Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value of do_hydro used before it is read in by read_hydro_params() #89

Open
n8xm opened this issue Mar 15, 2024 · 0 comments
Open

value of do_hydro used before it is read in by read_hydro_params() #89

n8xm opened this issue Mar 15, 2024 · 0 comments

Comments

@n8xm
Copy link
Contributor

n8xm commented Mar 15, 2024

On Line 308 of Nyx.cpp, the value of do_hydro is used in the following if statement :

  if (DefaultGeometry().isAnyPeriodic() || (!do_dm_particles && !do_hydro))

However, this if statement comes before the actual call to read_hydro_params(), which sets the value of do_hydro given the input file. I suspect that !do_hydro above always evaluates to true because its default value is zero.

If I am correct, then && !do_hydro should be removed from the if statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant