Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sound handling #3

Open
AMDmi3 opened this issue Dec 13, 2018 · 11 comments
Open

Improve sound handling #3

AMDmi3 opened this issue Dec 13, 2018 · 11 comments

Comments

@AMDmi3
Copy link
Owner

AMDmi3 commented Dec 13, 2018

Having to depend on SDL is strange. Qt multimedia or some simpler library, like maybe sndio, could be used. Also the sound plays with noticeable delay, which should be fixed too.

@yselkowitz
Copy link
Contributor

Unfortunately I don't hear any sound, even when enabled, in 1.9.0 when built with Qt6. 1.9.0 with Qt5 is fine though, as is 1.8.0 regardless of Qt version.

@AMDmi3
Copy link
Owner Author

AMDmi3 commented Feb 22, 2023

Are there any messages on console? Is there sound in any other qt6-multimedia consumers?

@yselkowitz
Copy link
Contributor

now that you mention it, I see five of these with the affected build:

QNetworkRequest::setHeader: QVariant of type QDateTime cannot be used with header Last-Modified

I'd have to find another consumer of Qt6Multimedia to test there.

@AMDmi3
Copy link
Owner Author

AMDmi3 commented Feb 22, 2023

The fact that there are five of these does suggest that these are related to attempts to load 5 sounds the game contains. That it mentions http headers is completely unexpected though, I'd never expect QUrl::fromLocalFile to involve any networking. Perhaps something related to it is broken or misused.

@yselkowitz
Copy link
Contributor

Does any of https://doc.qt.io/qt-6/qtmultimedia-changes-qt6.html apply to the code here?

@AMDmi3
Copy link
Owner Author

AMDmi3 commented Feb 23, 2023

Not really. Should probably read qt code a bit to understand what may be happening here, in the meantime could you try dumping source of an effect after its creation in initSoundEffect? Also, which qt version do you have?

@yselkowitz
Copy link
Contributor

Sorry, I'm not sure how to go about doing that. But I can tell you I'm using Qt 6.4.2.

@AMDmi3
Copy link
Owner Author

AMDmi3 commented Feb 23, 2023

Ok, I'm afk till next week, then I'll meke a branch for debugging this.

@AMDmi3
Copy link
Owner Author

AMDmi3 commented Feb 27, 2023

Try sound-debug branch please.

@yselkowitz
Copy link
Contributor

I'm not seeing any of the debug output with qt6, so it seems it's not getting that far?

@AMDmi3
Copy link
Owner Author

AMDmi3 commented Feb 27, 2023

Are you sure you've built from the right branch and haven't disabled sound support (ENABLE_SOUND)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants