Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchNOrb? #27

Open
karsar opened this issue May 27, 2024 · 3 comments
Open

SchNOrb? #27

karsar opened this issue May 27, 2024 · 3 comments

Comments

@karsar
Copy link

karsar commented May 27, 2024

It is mentioned that SchNOrb is implemented. Where in the code can I see it? Or better yet, how do I load the SchNOrb model checkpoint? Why is there no PhisNet YAML file in the model config directory to run it with run.py? Are there reasons for that? Running the PhisNet example for the test, as described in the PhisNet folder, produces an error:

from .hamiltonian_dataset import *
ModuleNotFoundError: No module named 'training.hamiltonian_dataset'

I am trying to replicate the comparison table for Hamiltonian prediction using model checkpoints.

@KuzmaKhrabrov
Copy link
Contributor

KuzmaKhrabrov commented May 27, 2024

Hello! We are preparing a major update, which will be released in the beginning of June. In the meanwhile, please, use branch 1.0. SchNorb code is located in this repo: https://github.com/KuzmaKhrabrov/SchNOrb
Unfortunately we don’t plan to add PhiSNet or SchNOrb into lightning pipeline soon

@karsar
Copy link
Author

karsar commented Jul 9, 2024

It seems that the major update does not contain SchNorb code. In fact, running https://github.com/KuzmaKhrabrov/SchNOrb has the same problem as the original SchNorb. While trying to import schnorb an error occurs:

from schnetpack import Properties
ImportError: cannot import name 'Properties' from 'schnetpack'

so scripts do not work with schnetpack version installed with nablaDFT...

Let's say I want to load provided checkpoint for the pretrained SchNOrb and run a test on some of the provided test sets to validate nablaDFT numbers, how would I do that? I can run PaINN and check the claims, as an example.

@KuzmaKhrabrov
Copy link
Contributor

Hello!

Let's say I want to load provided checkpoint for the pretrained SchNOrb and run a test on some of the provided test sets to validate nablaDFT numbers, how would I do that?

Unfortunately, to do that you need to make a separate environment and install SchNOrb from the repo: https://github.com/KuzmaKhrabrov/SchNOrb like

pip install .

I will update the Readme file and show an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants