Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xpk version prints the wrong git commit #342

Open
tengyifei opened this issue Jan 25, 2025 · 0 comments · May be fixed by #358
Open

xpk version prints the wrong git commit #342

tengyifei opened this issue Jan 25, 2025 · 0 comments · May be fixed by #358

Comments

@tengyifei
Copy link

If I first install xpk such that it is available in the $PATH, and then run xpk version in my own git repo (such as MaxText), it ends up fetching the git commit of my git repo instead of the one where xpk was installed from.
gcie added a commit to gcie/xpk that referenced this issue Feb 3, 2025
@gcie
fix xpk version git commit hash
a4140b8 
Add script in make install to save git commit hash in core.py when installing.

Fixes AI-Hypercomputer#342
@gcie gcie linked a pull request Feb 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix xpk version showing invalid git commit hash AI-Hypercomputer/xpk
1 participant
@tengyifei