Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable to change Jetstream version #1159

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

vivianrwu
Copy link
Collaborator

Description

Adds an environment variable to change JetStream version in Docker builds in case JetStream repository is broken at HEAD.

Tests

Manually tested by building the Dockerfile and testing the maxengine_server.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@vipannalla vipannalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@copybara-service copybara-service bot merged commit 9e91ccb into main Jan 24, 2025
16 checks passed
@copybara-service copybara-service bot deleted the vivianrwu/maxengine_docker branch January 24, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants