Skip to content

Easy parameter history access: priority for acheived or planned values #19

Description

@arthursloan

As part of PR #18 I made some initial QoL improvements for how data within the planning request can be accessed within a planner, namely adding an achieved_values and planned_values property to each parameter object so a user doesn't have to manually iterate through the list of parameter history objects stored in param_history. I'd like to add 2 capabilities to continue this:

  1. The ability to just get all of the parameter and results history as one table, either as a list of lists, pd array, etc.
  2. The ability to get a dictionary of the most recent condition and the result for planners in case the planners track their state outside of PyAres.

Both of these raise the question of how to handle the planned vs achieved values. Right now my thinking is that we use an "achieved priority" approach, where an achieved value is reported over the planned value if it exists. This seems the most consistent approach based on the requirement within ARES OS that the user has to specify that a parameter uses an achieved value, but I wanted to get other people's read on things. @nkleiner @rwaelder Let me know what you think about this approach.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions