Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter entry point #741

Closed
Tracked by #517
ns-rse opened this issue Nov 30, 2023 · 0 comments · Fixed by #1071
Closed
Tracked by #517

Filter entry point #741

ns-rse opened this issue Nov 30, 2023 · 0 comments · Fixed by #1071
Labels
ui Issues relating to User Interface v2.4.0

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Nov 30, 2023

Further to #517 add an entry point for topostats filter which loads files and saves them to HDF5 using io.save_topostats_file().

@ns-rse ns-rse changed the title Filter Filter entry point Nov 30, 2023
@ns-rse ns-rse added ui Issues relating to User Interface and removed user experience labels Nov 30, 2023
ns-rse added a commit that referenced this issue Jan 15, 2025
Closes #741

Adds the "swiss-army knife" component to run just filtering on files.

This involved modifying how the `.topostats` files are loaded and extracted because of the nesting (see #1068).

Tests currently fail because the `tests/resources/test_image/minicircle_small.topostats` is version `0.1` and doesn't
therefore work with the refactored structure (surprised #1068 passed all tests actualy!).

A separate commit will be made for updating this test file and the associated tweaking of tests.
ns-rse added a commit that referenced this issue Jan 15, 2025
Closes #741

Adds the "swiss-army knife" component to run just filtering on files.

This involved modifying how the `.topostats` files are loaded and extracted because of the nesting (see #1068).

Tests currently fail because the `tests/resources/test_image/minicircle_small.topostats` is version `0.1` and doesn't
therefore work with the refactored structure (surprised #1068 passed all tests actualy!).

A separate commit will be made for updating this test file and the associated tweaking of tests.
ns-rse added a commit that referenced this issue Jan 15, 2025
Closes #741

Adds the "swiss-army knife" component to run just filtering on files.

This involved modifying how the `.topostats` files are loaded and extracted because of the nesting (see #1068).

Tests currently fail because the `tests/resources/test_image/minicircle_small.topostats` is version `0.1` and doesn't
therefore work with the refactored structure (surprised #1068 passed all tests actualy!).

A separate commit will be made for updating this test file and the associated tweaking of tests.
@ns-rse ns-rse added the v2.4.0 label Jan 15, 2025
ns-rse added a commit that referenced this issue Jan 21, 2025
Closes #741

Adds the "swiss-army knife" component to run just filtering on files.

This involved modifying how the `.topostats` files are loaded and extracted because of the nesting (see #1068).

Tests currently fail because the `tests/resources/test_image/minicircle_small.topostats` is version `0.1` and doesn't
therefore work with the refactored structure (surprised #1068 passed all tests actualy!).

A separate commit will be made for updating this test file and the associated tweaking of tests.
ns-rse added a commit that referenced this issue Jan 21, 2025
Closes #741

Adds the "swiss-army knife" component to run just filtering on files.

This involved modifying how the `.topostats` files are loaded and extracted because of the nesting (see #1068).

Tests currently fail because the `tests/resources/test_image/minicircle_small.topostats` is version `0.1` and doesn't
therefore work with the refactored structure (surprised #1068 passed all tests actualy!).

A separate commit will be made for updating this test file and the associated tweaking of tests.
ns-rse added a commit that referenced this issue Jan 22, 2025
Closes #989

As I go through writing additional entry points for #517 I thought it worth documenting how to incorporate functionality
into the workflow in terms of adding it to the end-to-end pipeline and how to create an additional entry point so that
the specific functionality can be run on its own.

This is based on having done `filters` (#741) over a few weeks and as I go forward with subsequent (e.g. #742) which I've
started I may well tweak/revise these notes in case I've missed anything or made mistakes.
ns-rse added a commit that referenced this issue Jan 22, 2025
Closes #989

As I go through writing additional entry points for #517 I thought it worth documenting how to incorporate functionality
into the workflow in terms of adding it to the end-to-end pipeline and how to create an additional entry point so that
the specific functionality can be run on its own.

This is based on having done `filters` (#741) over a few weeks and as I go forward with subsequent (e.g. #742) which I've
started I may well tweak/revise these notes in case I've missed anything or made mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Issues relating to User Interface v2.4.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant