Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export multi-transform to ace-evaluator #22

Open
cortner opened this issue Feb 15, 2022 · 10 comments
Open

Export multi-transform to ace-evaluator #22

cortner opened this issue Feb 15, 2022 · 10 comments
Assignees
Labels

Comments

@cortner
Copy link
Member

cortner commented Feb 15, 2022

Not obvious to me where we should put our efforts:

  • write an export routine + an import routine and them re-implement this transform in C++
  • just hook David's C interface into LAMMPs directly?
@cortner
Copy link
Member Author

cortner commented Feb 16, 2022

@gabor1 your view would be useful here.

@gabor1
Copy link

gabor1 commented Feb 16, 2022

I am worried about running lammps with julia on HPCs. It could be that it is the future, but it would be nice not to be totally dependent on this, at least in the short run. IT would also be much less work to reimplement the transforms in PACE.

@cortner
Copy link
Member Author

cortner commented Feb 17, 2022

I don't think it is a quick hack to put the multi-transform into PACE. that's why I'm suggesting to think of both options. But we will take a look.

@cortner
Copy link
Member Author

cortner commented Jun 15, 2022

@WillBaldwin0 - does your spline export take care of this?

@WillBaldwin0
Copy link

My splines export only does the pair potential at the moment, since I haven't been messing around with the full ACE for repulsion stuff, so no multi transform

@cortner
Copy link
Member Author

cortner commented Jun 15, 2022

ok. but in principle it could be expanded to that, right?

@cortner
Copy link
Member Author

cortner commented Jun 15, 2022

but we leave it open and discuss it at one of the next software meetings.

@WillBaldwin0
Copy link

Yes it could, I'm not sure how that works on the PACE end though

@cortner
Copy link
Member Author

cortner commented Jun 15, 2022

I think the PACE end is already done that way.

@cortner
Copy link
Member Author

cortner commented Jan 20, 2023

just following up on this, I think we are going splines on everything so looking into exporting that to PACE is now urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants