Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #439 by adding eventdate statuses #536

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NoRePercussions
Copy link
Contributor

Resolves #439
Supersedes #534

This adds statuses to eventdates, so they can be marked cancelled or completed similar to events.

As of 45b6d1b a date marked cancelled can still be billed for if marked show billable or similar. This does not reflect how events work (cannot bill for cancelled events even if they are marked billable), but may be necessary for edge cases such as an event getting cancelled after an early setup but before the show.

@DaAwesomeP
Copy link
Member

I think this is missing some coordination with the overall event status. Since all events must have at least one event date, it seems like there should be validations for all event dates that determine the allowable overall event status. Examples:

  • All event dates must be marked as billing pending (or later "finished" statuses like canceled) for the overall event to be marked as billing pending.
  • All event dates must be marked as canceled for an event to be marked as canceled. If some eventdates took place but others did not, then the overall status should be billing pending or completed, not canceled.
  • There are definitely way more of these if you think through all of the permutations.

I think these validations are especially necessary until the billing system switches to being fully by event date and not by event (later pull).

Theoretically the overall event status could be determined from an expression based on the statuses of the event dates, but that will need some thought into edge cases.

I think a "set all at once" option is necessary for massive events like orientation (this could be in the frontend so that you can make exceptions). This should be a later pull.

I think I would much prefer having cancelled as an eventdate status instead of a checkbox since that mirrors how overall events work. If people billed for an event date, then it took place as far as billing is concerned.

@DaAwesomeP
Copy link
Member

DaAwesomeP commented Jan 22, 2024

Another thought: there should be a "blank" or null default state for eventdate statuses so that we don't have to edit old events when adding columns to the DB. Also useful for events that don't use the event date statuses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to cancel individual event date
2 participants