Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bitwise operators to VeLa #317

Closed
dbenn opened this issue Jan 10, 2023 · 2 comments · Fixed by #356
Closed

Add bitwise operators to VeLa #317

dbenn opened this issue Jan 10, 2023 · 2 comments · Fixed by #356
Assignees
@dbenn
Labels
VeLa VStar expression Language
Milestone
2.23.0

Comments

@dbenn
Copy link
Collaborator

dbenn commented Jan 10, 2023 •
edited
Loading

Add bitwise AND, OR, XOR, NOT, and shift operators (at least) to VeLa.

#314 gives a motivating example (see last comment).
@dbenn dbenn added the VeLa VStar expression Language label Jan 10, 2023
@dbenn dbenn self-assigned this Jan 10, 2023
@orionlee
Copy link
Collaborator

orionlee commented Jan 12, 2023 •
edited
Loading

For the motivational use case in #314 to work (BITWISE_AND(quality, 32) = 0), columns in observation details need to support integer type. Right now they are all string. See #322 (comment).
Update: tracked in #325

@dbenn
Copy link
Collaborator Author

dbenn commented Jan 12, 2023

@orionlee, I woke up last night and thought about a couple of things. This was one of them, so sent a note-to-self in the wee hours. :)

dbenn added a commit that referenced this issue May 11, 2023
@dbenn
#317: implemented bitwise AND, OR, NOT plus UTs
eb567f6
dbenn added a commit that referenced this issue May 11, 2023
@dbenn
#317: implemented XOR
51e8089
dbenn added a commit that referenced this issue May 11, 2023
@dbenn
#317: fixed XOR precedence
eab15dc
dbenn added a commit that referenced this issue May 13, 2023
@dbenn
#317: add left and right shift operators, binary and hex literals and…
76b1030 
… UTs
dbenn added a commit that referenced this issue May 13, 2023
@dbenn
#317: changed RA, Dec, Blend details to double, integer
579068e
@dbenn dbenn mentioned this issue May 15, 2023
Merged
@dbenn dbenn linked a pull request May 15, 2023 that will close this issue
325 observation details are always strings #356
Merged
@dbenn dbenn added this to the 2.23.0 milestone Aug 12, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbenn dbenn

Labels
VeLa VStar expression Language
Projects
VStar Development Issues
Archived in project
Milestone
2.23.0
Development

Successfully merging a pull request may close this issue.

325 observation details are always strings AAVSO/VStar
2 participants
@orionlee @dbenn