Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused libraries #3

Closed
juhitiwari opened this issue Sep 26, 2020 · 6 comments · Fixed by #9
Closed

Remove unused libraries #3

juhitiwari opened this issue Sep 26, 2020 · 6 comments · Fixed by #9
Labels
beginner Good for getting used to the code base enhancement New feature or request good first issue Good for newcomers only-iiitm

Comments

@juhitiwari
Copy link

juhitiwari commented Sep 26, 2020 •
edited
Loading

You might find some third-party libraries that are not being used, please remove them both from imports as well as from the project
@juhitiwari juhitiwari added good first issue Good for newcomers beginner Good for getting used to the code base enhancement New feature or request labels Sep 26, 2020
@dawksh
Copy link

dawksh commented Sep 27, 2020

Can I take this up?

@juhitiwari
Copy link
Author

Can I take this up?

Hey @devdaksh sure you can take this up. Raise a PR once the hacktoberfest starts so that you have one for the hacktoberfest. Till then you can get acquainted with the codebase. Do ask questions if you have any doubts

@dawksh
Copy link

dawksh commented Sep 28, 2020

great!

@dawksh
Copy link

dawksh commented Sep 28, 2020 •
edited
Loading

Should I also remove commented code and unused functions as well?

@juhitiwari
Copy link
Author

Should I also remove commented code and unused functions as well?

That will be the part of #2 issue. We have added that one for iiitm students only as we got so many responses from outside iiitm. But feel free to take this issue up! Sorry for the inconvenience. Also, if you find any bugs or any feature improvement do raise an issue :)

@dawksh
Copy link

dawksh commented Sep 30, 2020

I've done it, I'll make the PR in next couple of hours.

@dawksh dawksh mentioned this issue Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner Good for getting used to the code base enhancement New feature or request good first issue Good for newcomers only-iiitm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore-clean-code dawksh/gladiator
3 participants
@dawksh @juhitiwari @manishdangi98