Is it good to re-export the internal function ImportPathForDir

[git-hulk]

Currently, we're writing the gqlgen's plugin to generate some internal files, and it needs to use ImportPathForDir to get the package name, but it's an internal function. So I'm wondering if it's good to re-export this function in the codegen package? cc @StevenACoffman

[StevenACoffman]

You are writing your own custom plugin that lives outside of gqlgen's codebase? Or are contributing a plugin to gqlgen?

Not sure exactly what you mean, so not sure about the pros and cons. Watch out for cyclical dependencies.

[git-hulk]

Thanks for your prompt reply. Yes, we have implemented the metric(Prometheus) and tracing(NewRelic) extensions for gqlgen's server. We would like to write a plugin to generate the server entry point and some internal configuration files.

Or are contributing a plugin to gqlgen?

It's all about the internal logic, so I think it's not useful for the community. But by the way, I'm not sure if it sounds good to contribute back some extensions to the community like metric(Prometheus) and tracing(NewRelic/OpenTelemetry/...)? If yes, I can raise a proposal to discuss about this.

[StevenACoffman]

Actually both would be quite helpful! You might compare your implementation to the existing prometheus plugin: https://github.com/99designs/gqlgen-contrib

I have not gotten as many contributions to that repository as I have to this one, so it could use some sprucing up.

[git-hulk]

Actually both would be quite helpful! You might compare your implementation to the existing prometheus plugin: https://github.com/99designs/gqlgen-contrib

I did go through the gqlgen repository and missed out the gqlgen-contrib. Thanks for your information, will take a look.