Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wget from recovery-flash-uefi-prebuilt.sh does not re-download when it should #42

Open
v0lker opened this issue Feb 12, 2019 · 0 comments

Comments

@v0lker
Copy link
Contributor

v0lker commented Feb 12, 2019

e. g. with revision #85 of the UEFI firmware, first downloading the debug version, then release works because the time stamp of the release version seems to be after the debug version; but the other way, wget is going to skip the download and you'll stay at the version you're at:

[...]
File ‘MD5SUMS.txt’ not modified on server. Omitting download.
[...]

actually it's worse - if you want an older version in general, the same is going to happen, so you cannot downgrade without (re)moving the folder.

what i'd suggest is to

a) name the download folder not uefi but uefi-{debug,release}-{version} or
b) to always download all of the files which is going to create some overhead
c) to unconditionally download the md5sums file, then compare and act accordingly.

i think a) is nice because apart from making it obvious which version(s) one has downloaded, it's the least amount of work (should work even with -v latest), so even if c) is chosen (because it is the correctest solution), a) would be nice to have as well.

could provide PR if you let me know which way you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant