Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipefail, oneline example, shellcheck to README #2

Open
icetbr opened this issue Sep 29, 2021 · 3 comments
Open

Add pipefail, oneline example, shellcheck to README #2

icetbr opened this issue Sep 29, 2021 · 3 comments

Comments

@icetbr
Copy link

icetbr commented Sep 29, 2021

don't mean to !/bin/bash, but...

use the pipefail Luke!

kool kids do it in one line, add an example, THE ENDING ; is REQUIRED

deploy() { echo "I am ${FUNCNAME[0]}ing in one line!"; }

for the README

shellcheck yourself before you wreck yourself

a linter for bash scripts
https://marketplace.visualstudio.com/items?itemName=timonwong.shellcheck

some nice tips

https://bertvv.github.io/cheat-sheets/Bash.html

a good Make write up

make has a nice auto detection of files changed, and will only build what has changed
https://spin.atomicobject.com/2021/03/22/makefiles-vs-package-json-scripts/

my 1cent

npm run start has a nagging delay of a few miliseconds, ./run.sh start does not, the article above shows an example

@icetbr
Copy link
Author

icetbr commented Feb 20, 2022

Well, I made my own, thank you for the inspiration!

https://github.com/icetbr/run

@Vad1mo
Copy link
Member

Vad1mo commented Feb 20, 2022

hey @icetbr sorry somehow your contribution went under my radar. :( This was not on purpose.

Would be happy to collaborate with you, if you are up for it can add you as a maintainer.

@icetbr
Copy link
Author

icetbr commented Feb 21, 2022

Hello, thank you for your reply. I just gave do.sh a little touch up to suite my tastes, I expect everyone that uses it to do the same.

Does my version replace yours? Does do.sh user base find it better? I don't know. Maybe we wait other people input, and to to see if it gains more traction? Maybe just leave my comment here as a way to link both our projects?

I don't mean to take away the credit for "inventing" this idea by any means. I just want people to be aware of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants