Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows command & customization #8

Open
isteven opened this issue May 23, 2016 · 6 comments
Open

Windows command & customization #8

isteven opened this issue May 23, 2016 · 6 comments

Comments

@isteven
Copy link

isteven commented May 23, 2016

Hi,

Thanks for the great plugin, it really helps me!

Small bugs:

  1. On the plugin settings page, I saw the default Mac toggle, which is alt-cmd-l. On Windows this would translate into alt-ctrl-l, but somehow it doesn't work. I know this can be configured manually, but I thought I'd just let you know.

  2. When I click a function, it doesn't always bring me to the exact line, but sometimes 2-3 lines above.

Other than those, I would love to see further customization if possible, example:

  • Only toggle on certain file types
  • What symbols to show: object, variable, etc.

Thanks & keep up the good work!

@7ute
Copy link
Owner

7ute commented May 23, 2016

Hi,
Thank you for your feedback :)

1/ Yeah, i should probably add some linux/windows dedicated shortcut. If alt-ctrl-l ain't taken already, that could do it. I don't have Atom installed on a windows machine so if you can confirm that this shortcut is free on vanilla atom, I'll add it.
2/ Ah yes, I noticed that one. It may have to do with some regexes matching line starting carriage returns ^^'. I'll fix that in next release.

As for the fine tuning, I was thinking of something like that.
Maybe some sort of hierarchical table having sources types as parents, and symbols as children, and checkboxes to activate/deactivate sources or symbols.
But that's a bit heavy for now, and by keeping the symbol list light, we may avoid the need of such settings? :)

Cheers!

@7ute 7ute added the bug label May 23, 2016
@isteven
Copy link
Author

isteven commented May 24, 2016

Hi,

So far, I can confirm that no default Atom command using alt-ctrl-l / ctrl-alt-l. So it's still free.

Instead of a hierarchical table, perhaps you can just provide a simple textfield so people can just put a space-separated file types, such as:

  • Only toggle on these file extensions: ".php .js .css .java".

Same for the symbols to show/hide, such as:

  • Hide these symbols: "inline-function object array variable".

So basically they can be whitelist or blacklist, it's up to you. (However, for the symbols show/hide, you need to tell people what's settings are available).

Also, perhaps a simple legend is needed for the square icons you put in front of each function names. I'm a Javascript developer, and I saw "F" and "M". I'm sure "F" means function, but what is "M"?

Cheers.

@7ute
Copy link
Owner

7ute commented May 31, 2016

"M" is for "Method" :)
1/ and 2/ Fixed on 2.2 release

Ill keep that ticket open, to get ideas when refactoring the settings!

@7ute 7ute added enhancement and removed bug labels May 31, 2016
@isteven
Copy link
Author

isteven commented Jun 1, 2016

Oh M for method.. silly me didn't realize it in the first place.

Thank you for the fixes, much appreciated, and, I look forward to the settings customization :)

Cheers.

@isteven
Copy link
Author

isteven commented Jun 2, 2016

Hi @7ute,

I have tested & I can confirm that the Windows shortcut is now working OK.

However, unfortunately problem no. 2) still exists. Also, upon further checking, it seems that it only happens on Functions (F). The Methods (M) seem to be spot on, at least from what I tested.

Cheers.

@7ute
Copy link
Owner

7ute commented Jun 2, 2016

Oh that's true, thanks for noticing it!
I forgot to fix that "jump to line" bug on JS. It seems to be ok for PHP though.
It'll be done for next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants