Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI positioning / Docks integration #42

Open
onetrev opened this issue Apr 2, 2017 · 8 comments
Open

UI positioning / Docks integration #42

onetrev opened this issue Apr 2, 2017 · 8 comments

Comments

@onetrev
Copy link

onetrev commented Apr 2, 2017

I believe the Symbols List should display to the left, not the right, of Atom Tool Bar. Screenshot below... I believe most other packages display to the left of the Tool Bar, so hopefully it is an easy tweak.

image

This is a great addition to Atom though. Thank you so much for making this package! It's a big step up from Symbols Tree View package I had been using for ages.

@mbuc82 mbuc82 added the bug label Apr 7, 2017
@onetrev
Copy link
Author

onetrev commented May 13, 2017

Related to this bug, a wishlist item for sure, but it would be awesome if is in fixing this bug Symbols List could be updated to make us of the coming "Docks" feature in Atom 1.17? Docks is easily one of the biggest / best new features in Atom since it went to v1.0 (in my opinion)!

@7ute
Copy link
Owner

7ute commented May 14, 2017

Hi,
Thanks your support!
Indeed the upcoming "Docks" feature looks promising, and would simplify the sidebar management ( and allow moving it to other locations, cf. #31 ).

As for now, and the object of this ticket, I assume you're using flex-tool-bar, which relies on tool-bar. Unfortunatly, that package seems to rely on the default priority for the toolbar position.
We could put a setting that allows to set a priority ( SymbolsList.coffee:46 ) superior to 100 (panels defaults, lower is closer to the edge).
Or we could wait for the docks feature and see how it manages panels priorities?

@onetrev
Copy link
Author

onetrev commented May 14, 2017

You're very welcome, but more so, thank you for working on this package! You are right, I am using tool-bar package (linked above in my initial issue request).

I know I've seen a number of other packages that seem to be correctly to the left of the tool-bar, but I can't find any right now unfortunately. I was trying to find one so I could check what they did. But for now, as it sounds like a quick fix, I would love to have that option added to resolve this in the short term. Please!

And it's cool that Docks could tackle multiple issues for you! Based on past Atom release timing, it should be in the production version of Atom (1.17) in the next few weeks at most.

@onetrev
Copy link
Author

onetrev commented May 16, 2017

Found / remembered a package that displays correctly. The competing package to this one ;) ... Symbols Tree View. By default it appears nicely to the left side of Atom Tool Bar.

@7ute
Copy link
Owner

7ute commented May 16, 2017

Might have to do with the loading priority, because after completely removing the priority in SymbolsList ( SymbolsList.coffee:46, removing 'priority:0' ) to mimic Symbols Tree View, the sidebar appears correctly on the left side. Then, if I restart, the sidebar moves further from the side, as depicted in your screenshot.

@onetrev
Copy link
Author

onetrev commented May 17, 2017

And there we have it, Atom 1.17 is out, so Docks is now available to all and already in use by a number of packages (i.e. Linter-UI-Default and Tree View). So maybe we should just close out this issue and migrate to using Docks instead? Sounds easy to implement as well, though that's easy for me to say.

@onetrev
Copy link
Author

onetrev commented Aug 30, 2017

I wonder if this bug shouldn't be closed (and a new one created regarding adding Docks support), or the title changed, because "Docks" is now fully part of Atom, and the recommended way for sidebar packages to be shown?

@mbuc82
Copy link
Collaborator

mbuc82 commented Aug 30, 2017

Hey @onetrev ,

i guess you're right, as we are currently working on the Docks integration.
I will not close this issue, but change the title in terms of better understanding.

Regards
Marco

@mbuc82 mbuc82 changed the title UI positioning when using Atom Tool Bar UI positioning / Docks integration Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants