Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CleanUpVisitor doesn't do much. #12

Open
71 opened this issue May 31, 2017 · 1 comment
Open

CleanUpVisitor doesn't do much. #12

71 opened this issue May 31, 2017 · 1 comment
Assignees
@71
Labels
bug enhancement feature
Milestone
0.2

Comments

@71
Copy link
Owner

71 commented May 31, 2017

The point of the CleanUpVisitor is to remove every single dependency to Cometary. That means namespaces, classes, attributes, metadata references, etc. It currently only removes usings that start with Cometary, and destroys the program as it does it.

It should also be smarter -- not only should it remove references to Cometary, but also to packages that depend on it.
@71 71 added this to the 0.2 milestone May 31, 2017
@71 71 self-assigned this May 31, 2017
@71
Copy link
Owner Author

71 commented Jun 30, 2017

The CleanUpVisitor was renamed to CleanUpRewriter in 2cc21e8.
Now, extensions should manually add Hooks to clean up their code, thanks to the new CleanUp static class.

This is a big change, but right now, the source code still doesn't clean up everything. Also, references aren't deleted correctly either, which is why I'm letting this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@71 71

Labels
bug enhancement feature
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
1 participant
@71